fix: move emoji suggestions to portals by allroundexperts · Pull Request #24541 · Expensify/App

allroundexperts · 2023-08-14T15:39:56Z

Details

This PR fixes the issue where on extremely small short height screens, the mention options were hidden behind the header.

In my original proposal, I proposed to remove overflowHidden style from the ReportActions container but upon further testing I found out that the proposed approach had another shortfall. Specifically, the report actions were not stacking behind the header correctly. As such, I decided to proceed with moving the menu inside React portals.

Fixed Issues

$ #22930
PROPOSAL: #22930 (comment)

Tests

Open any chat and resize the browser window such that it has extremely small height.
Type @ in the composer and verify that the mention options are not hidden behind the report header.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Open any chat and resize the browser window such that it has extremely small height.
Type @ in the composer and verify that the mention options are not hidden behind the report header.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-08-14.at.6.52.20.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-14.at.6.58.47.PM.mov

Mobile Web - Safari

Screen.Recording.2023-08-14.at.6.58.14.PM.mov

Desktop

Screen.Recording.2023-08-14.at.6.54.44.PM.mov

iOS

Screen.Recording.2023-08-14.at.7.01.00.PM.mov

Android

Screen.Recording.2023-08-14.at.7.00.19.PM.mov

melvin-bot · 2023-08-14T15:40:02Z

@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

robertKozik · 2023-08-17T07:43:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

iOS.-.web.MP4

Desktop

desktop.mov

iOS

Screen.Recording.2023-08-17.at.10.41.05.mov

Android

android.-.native.mov

robertKozik · 2023-08-17T09:43:30Z

@allroundexperts I've found that AutoCompleteSuggestion is still hidden under, for this time not header but the paypal.me component under header. Check out the video:

Screen.Recording.2023-08-17.at.11.35.44.mov

robertKozik

One small question to the code

allroundexperts · 2023-08-17T10:07:03Z

@allroundexperts I've found that AutoCompleteSuggestion is still hidden under, for this time not header but the paypal.me component under header. Check out the video:

Screen.Recording.2023-08-17.at.11.35.44.mov

@robertKozik I thought this was supposed to be tested on web only but I was incorrect it seems. Also, react portals aren't really on native, so I have to rethink this.

robertKozik · 2023-08-17T10:22:33Z

dang, you're right about the browser thing. But if we can fix it on all platforms, it would be better to do so. Let me know what you think about squeezing in other platforms too

allroundexperts · 2023-08-17T10:23:58Z

dang, you're right about the browser thing. But if we can fix it on all platforms, it would be better to do so. Let me know what you think about squeezing in other platforms too

Squeezing as an reducing the number of options to show depending on the height?

robertKozik · 2023-08-17T10:26:47Z

no no, What are your thoughts on expanding the scope of this PR to include the native part as well? As I'm also open to stay with this as browser only, and treat the native as new issue then

allroundexperts · 2023-08-17T10:29:43Z

Right. We can make use of a library like https://github.com/gorhom/react-native-portal to make this work on both web and native. Do you think we should use it?

allroundexperts · 2023-08-17T10:47:20Z

Also, If we decide to use the above mentioned library, it would be better to migrate all of our React portals to use that library instead. I'm fine with handling that as a separate ticket!

robertKozik · 2023-08-18T11:59:58Z

Well, it seems like there's a completely different situation on the native side. I suggest we separate these two and prioritize pushing the web side of things forward. The native part is more complex and relatively uncommon.

I'll proceed with review of this one

robertKozik · 2023-08-18T16:03:12Z

On mWeb-safari I have encountered problems with the position of the suggestions view. @allroundexperts in order to trigger this behaviour you need to have screen keyboard on:

Screen.Recording.2023-08-18.at.17.53.28.mov

allroundexperts · 2023-08-18T16:07:28Z

On mWeb-safari I have encountered problems with the position of the suggestions view. @allroundexperts in order to trigger this behaviour you need to have screen keyboard on:

Screen.Recording.2023-08-18.at.17.53.28.mov

I will check this and get back. Thanks a lot for the heads up @robertKozik!

allroundexperts · 2023-08-18T22:35:08Z

@robertKozik Fixed.

Screen.Recording.2023-08-19.at.3.34.22.AM.mov

robertKozik

LGTM, lets push it forward 🚀

OSBotify · 2023-08-24T22:39:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-28T18:50:08Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:19:11Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:57:36Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:57:54Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

roryabraham · 2023-11-21T00:43:41Z

+        return componentToRender;
+    }
+
+    return ReactDOM.createPortal(<View style={StyleUtils.getBaseAutoCompleteSuggestionContainerStyle({left, width, bottom})}>{componentToRender}</View>, document.querySelector('body'));


Not a huge deal, but I think we should strive to use the context-based @gorhom/portal instead of ReactDOM.createPortal wherever possible, to reduce unnecessary differences between code across platforms.

If we can keep our code in pure React Native (w/ react-native-web of course), we should

allroundexperts added 3 commits August 14, 2023 19:03

fix: move auto complete menu to portals

1a84f30

Merge branch 'main' into fix-22930

a03327f

fix: invalid prop types

98360e9

allroundexperts requested a review from a team as a code owner August 14, 2023 15:39

melvin-bot Bot requested review from robertKozik and removed request for a team August 14, 2023 15:40

fix: lint errors

e336701

allroundexperts mentioned this pull request Aug 14, 2023

[HOLD for payment 2023-09-06] [$1000] Mweb – Assign Task – Mention options hides behind header. #22930

Closed

6 tasks

robertKozik reviewed Aug 17, 2023

View reviewed changes

Comment thread src/components/AutoCompleteSuggestions/autoCompleteSuggestionsPropTypes.js Outdated

allroundexperts added 5 commits August 19, 2023 00:59

Merge branch 'main' into fix-22930

bf05c4d

feat: safari iOS bug for position

56a3cb2

feat: resize window fix

52cc294

merge with main

5bdc49a

lint errors

aad3456

fix: use already defined ref prop types

a8b20ec

robertKozik approved these changes Aug 21, 2023

View reviewed changes

melvin-bot Bot requested a review from AndrewGable August 21, 2023 15:45

AndrewGable approved these changes Aug 24, 2023

View reviewed changes

AndrewGable merged commit 7fa5690 into Expensify:main Aug 24, 2023

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

roryabraham reviewed Nov 21, 2023

View reviewed changes

Uh oh!

Conversation

allroundexperts commented Aug 14, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 14, 2023

Uh oh!

robertKozik commented Aug 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

robertKozik commented Aug 17, 2023

Uh oh!

robertKozik left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

allroundexperts commented Aug 17, 2023

Uh oh!

robertKozik commented Aug 17, 2023

Uh oh!

allroundexperts commented Aug 17, 2023

Uh oh!

robertKozik commented Aug 17, 2023

Uh oh!

allroundexperts commented Aug 17, 2023

Uh oh!

allroundexperts commented Aug 17, 2023

Uh oh!

robertKozik commented Aug 18, 2023

Uh oh!

robertKozik commented Aug 18, 2023

Uh oh!

allroundexperts commented Aug 18, 2023

Uh oh!

allroundexperts commented Aug 18, 2023

Uh oh!

robertKozik left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

OSBotify commented Aug 28, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 31, 2023

Uh oh!

roryabraham Nov 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

robertKozik commented Aug 17, 2023 •

edited

Loading

roryabraham Nov 21, 2023 •

edited

Loading