Display status in chats by perunt · Pull Request #24526 · Expensify/App

perunt · 2023-08-14T10:59:08Z

Details

Fixed Issues

$ #23134
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Before you need setup the status:

Log in using account A.
Navigate to Settings -> Profile -> Status.
Create a new status for account A.
Also, you need to enable betas 'customStatus'

Viewing Status in Chat:

Log in using account B.
Open a chat where account A is a participant.
Verify if the status of account A is displayed next to their name.

Hovering over the Status (Web only):

Hover over the status icon next to account A's name.
Check if the status text is displayed as a tooltip (if one was set in ).

Checking Status in Direct Chat:

Open a direct chat with account A.
Ensure that the status is displayed next to account A's name.

Status Expiry Tooltip:

Hover over the status icon (or text) for account A.
The tooltip should display an expiration note, e.g., "(Until tomorrow)". This indicates that the status is valid until the end of the current day.
Note: In future releases, the ability to change the expiration duration will be added.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

![image](https://github.com/Expensify/App/assets/48593211/6d4829f7-a761-4c09-bd8a-399ca59116df)

melvin-bot · 2023-08-14T12:36:23Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…pensify#23134-display-status-chats

Santhosh-Sellavel · 2023-08-14T20:27:22Z

@stitesExpensify Can you add me to customStatus beta

Santhosh-Sellavel · 2023-08-15T19:06:41Z

+        untilTomorrow: 'Hasta mañana',
+        untilTime: ({time}) => `Hasta las ${time}`,


@stitesExpensify Can you confirm translations are good internally?

Unfortunately we need to change this 😞

When the time starts with 1 we need it to be Hasta la

Guilty as charged, lo siento, my Spanish is bad

No es una problema. Yo también.

That being said, I think I was unclear. It needs to be:

01:xx -> Hasta la
Any time that does not start with 01 including 00 -> Hasta las

Thanks for the details!
What about a format with days like Until 06-29 11:30AM. Should we use Hasta el día?

Santhosh-Sellavel · 2023-08-15T19:07:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

WebDesktop.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-08-16.at.12.31.58.AM.mov

iOS & Android

Screen.Recording.2023-08-16.at.12.29.41.AM.mov

Santhosh-Sellavel

Except this LGTM!

All yours @stitesExpensify!

perunt · 2023-08-16T17:38:14Z

@stitesExpensify

stitesExpensify

Code looks good, one small change!

stitesExpensify

LGTM!

OSBotify · 2023-08-16T19:31:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-17T02:20:10Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.55-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-21T22:26:43Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.56-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-24T03:09:44Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.56-24 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

parasharrajat · 2023-10-13T06:12:08Z

+
+    userReportStatusEmoji: {
+        fontSize: variables.fontSizeNormal,
+        marginRight: 4,


We should also prevent shrinking as its view will be shrank when there is not enough space. This caused #27149

perunt added 3 commits August 14, 2023 12:47

add getStatusUntilDate

a77c6f3

fix saving clearAfter date

6ed5ca6

add emoji next to avatar

ac5ef68

perunt marked this pull request as ready for review August 14, 2023 12:36

perunt requested a review from a team as a code owner August 14, 2023 12:36

melvin-bot Bot removed the request for review from a team August 14, 2023 12:36

melvin-bot Bot requested a review from Santhosh-Sellavel August 14, 2023 12:36

stitesExpensify self-requested a review August 14, 2023 13:19

Merge branch 'main' of https://github.com/Expensify/App into feat/#Ex…

91092ff

…pensify#23134-display-status-chats

Santhosh-Sellavel suggested changes Aug 14, 2023

View reviewed changes

Comment thread src/libs/DateUtils.js Outdated

Santhosh-Sellavel reviewed Aug 14, 2023

View reviewed changes

Comment thread src/pages/home/report/ReportActionItemSingle.js Outdated

perunt added 2 commits August 15, 2023 15:00

translations

6cb772e

use Boolean()

99b9ca0

Santhosh-Sellavel reviewed Aug 15, 2023

View reviewed changes

Santhosh-Sellavel approved these changes Aug 15, 2023

View reviewed changes

perunt added 3 commits August 16, 2023 10:02

change translations

5adaabb

update es translations

8993953

fix regExp

b002bf6

stitesExpensify requested changes Aug 16, 2023

View reviewed changes

Comment thread src/libs/RegExp.js Outdated

move regExp to const

6ff5f6a

stitesExpensify approved these changes Aug 16, 2023

View reviewed changes

stitesExpensify merged commit 0b2d5c8 into Expensify:main Aug 16, 2023

OSBotify mentioned this pull request Aug 17, 2023

Deploy Checklist: New Expensify 2023-08-17 #25160

Closed

75 tasks

perunt mentioned this pull request Aug 18, 2023

[NoQA] Move regexp #25475

Merged

59 tasks

OSBotify mentioned this pull request Aug 21, 2023

Deploy Checklist: New Expensify 2023-08-21 #25625

Closed

melvin-bot Bot mentioned this pull request Aug 21, 2023

[HOLD for payment 2023-08-28] [$1000] [Custom Status] Display status emojis in chats #23134

Closed

parasharrajat reviewed Oct 13, 2023

View reviewed changes

parasharrajat mentioned this pull request Oct 13, 2023

[HOLD for payment 2023-10-10] [$500] Chat - Status emoji is not fully visible in conversation page #27149

Closed

6 tasks

		untilTomorrow: 'Hasta mañana',
		untilTime: ({time}) => `Hasta las ${time}`,

Uh oh!

Conversation

perunt commented Aug 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 14, 2023

Uh oh!

Santhosh-Sellavel commented Aug 14, 2023

Uh oh!

Uh oh!

Uh oh!

Santhosh-Sellavel Aug 15, 2023

Choose a reason for hiding this comment

Uh oh!

stitesExpensify Aug 15, 2023

Choose a reason for hiding this comment

Uh oh!

perunt Aug 16, 2023

Choose a reason for hiding this comment

Uh oh!

stitesExpensify Aug 16, 2023

Choose a reason for hiding this comment

Uh oh!

perunt Aug 16, 2023

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented Aug 15, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

perunt commented Aug 16, 2023

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 16, 2023

Uh oh!

OSBotify commented Aug 17, 2023

Uh oh!

OSBotify commented Aug 21, 2023

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

parasharrajat Oct 13, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

perunt commented Aug 14, 2023 •

edited

Loading