[Feat #23131] Display status on user page by perunt · Pull Request #24330 · Expensify/App

perunt · 2023-08-09T16:41:41Z

Details

Fixed Issues

$ #23131
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Test Case 1: Status with Emoji + Text

Use Account A to create a status (emoji + text).
Switch to Account B and open the user details page of Account A.
Verify if Account A has the status displayed.

Test Case 2: Status with Only Emoji

Use Account A to create a status (only emoji).
Switch to Account B and open the user details page of Account A.
Verify if Account A has the status displayed.

Test Case 3: Status with Extended Text

Use Account A to create a lengthy status.
Switch to Account B and open the user details page of Account A.
Verify if Account A has the status displayed and if it fits correctly.
Check if the tooltip renders correctly.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

videos here -->

perunt · 2023-08-09T16:43:51Z

+    const defaultText = draftEmojiCode ? draftText : currentUserStatusText;
+    const customStatus = draftEmojiCode ? `${draftEmojiCode} ${draftText}` : `${currentUserEmojiCode || ''} ${currentUserStatusText || ''}` ;


It's a fix for saving an empty status

melvin-bot · 2023-08-09T17:25:50Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-08-09T17:33:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

rushatgabhane · 2023-08-09T17:47:07Z

@perunt could you please add testing steps so that QA can test

rushatgabhane

LGTM

perunt · 2023-08-09T19:19:21Z

hey, @shawnborton need your help 😃
We use a 'one line' style for items. The status is capped at 100 words, so I added a tooltip for the full message. Should I format it over multiple lines?

shawnborton · 2023-08-09T19:33:12Z

What does this look like without the tooltip? I am thinking we can just use the same pattern as a push-to-page row that can't be edited. That being the case, maybe we don't add the one-line cap but rather enforce a character limit when creating the status.

stitesExpensify

Looking good! One comment and waiting for Shawn's opinion on no tooltip (when those images are posted) before I merge

perunt · 2023-08-09T19:47:42Z

I've noticed some people leave really long 'statuses'. It might make sense to limit the characters to the length of one sentence.

shawnborton · 2023-08-09T19:52:04Z

Yeah, I don't think we should limit the display of the status. So I would remove the one-line truncation you have. And yeah, rather, let's add a character limit to the status itself.

stitesExpensify · 2023-08-09T20:06:02Z

What do you think we should set the limit to? Looks like slack does 100

stitesExpensify · 2023-08-09T20:27:08Z

Not technically related to this PR but can you update this line to be translated please? https://github.com/Expensify/App/pull/24330/files#diff-06be2d0d91e1fd806520ae7745785251dbd0c77d86ee71b828b540cfe42596ccR81

perunt · 2023-08-10T08:47:04Z

Nice, then just summarize. I'll keep the limit to 100 characters. This amount of characters fits in 2 lines on the smallest screen (iPhone SE). The tooltip has been removed. I'll drop the screenshot below

stitesExpensify · 2023-08-10T13:51:10Z

Wow that status really is perfectly crafted. 100 characters as an actual sentence is 👨‍🍳

stitesExpensify

Code is looking great but I found one bug, when you are on a user's profile and their status changes, it is not automatically reflected. You need to close the profile and then go back into it to see the update. Can we change it so that when the onyx changes the profile also changes?

perunt · 2023-08-11T07:57:06Z

Hmm, that's weird because it works for me
do we speak about the same profile screen?

Untitled.mov

stitesExpensify · 2023-08-11T15:06:32Z

Hm maybe my pusher was just being weird or something. Let me try again

stitesExpensify · 2023-08-11T15:23:38Z

Yep my pusher was just not working locally.

OSBotify · 2023-08-11T15:27:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-14T20:04:37Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.54-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-14T21:04:53Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.54-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

JmillsExpensify · 2023-08-16T03:26:08Z

@stitesExpensify Do you mind confirming that @rushatgabhane that @rushatgabhane is owed the standard $1k for this PR review?

stitesExpensify · 2023-08-16T15:24:59Z

Yep, standard 1k!

OSBotify · 2023-08-17T02:55:29Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.54-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

JmillsExpensify · 2023-08-24T05:01:34Z

Thanks so much! This $1k payment is approved for payment via NewDot.

perunt added 6 commits August 6, 2023 15:36

Merge branch 'main' of https://github.com/margelo/expensify-app-fork

efd5323

Merge branch 'main' of https://github.com/margelo/expensify-app-fork

4c5aab5

Merge branch 'main' of https://github.com/Expensify/App

939afdb

fix saving empty status

cf2f55b

add status line

fe48a9b

add tooltip for status

5eb0e86

perunt commented Aug 9, 2023

View reviewed changes

center the position of the tooltip

72c1ef0

perunt marked this pull request as ready for review August 9, 2023 17:25

perunt requested a review from a team as a code owner August 9, 2023 17:25

melvin-bot Bot requested review from rushatgabhane and removed request for a team August 9, 2023 17:25

rushatgabhane reviewed Aug 9, 2023

View reviewed changes

Comment thread src/pages/ProfilePage.js Outdated

rushatgabhane approved these changes Aug 9, 2023

View reviewed changes

melvin-bot Bot requested a review from stitesExpensify August 9, 2023 17:53

refactor conditional rendering from ternary to logical AND

a722da7

rushatgabhane approved these changes Aug 9, 2023

View reviewed changes

stitesExpensify requested changes Aug 9, 2023

View reviewed changes

Comment thread src/pages/ProfilePage.js

add translations and use betas flag

5fb31e7

stitesExpensify reviewed Aug 10, 2023

View reviewed changes

stitesExpensify approved these changes Aug 11, 2023

View reviewed changes

stitesExpensify merged commit 29e6b61 into Expensify:main Aug 11, 2023

OSBotify mentioned this pull request Aug 14, 2023

Deploy Checklist: New Expensify 2023-08-14 #24550

Closed

49 tasks

melvin-bot Bot mentioned this pull request Aug 17, 2023

[HOLD for payment 2023-08-24] [Custom Status] Display status on users' profiles #23131

Closed

		const defaultText = draftEmojiCode ? draftText : currentUserStatusText;
		const customStatus = draftEmojiCode ? `${draftEmojiCode} ${draftText}` : `${currentUserEmojiCode \|\| ''} ${currentUserStatusText \|\| ''}` ;

Uh oh!

Conversation

perunt commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

perunt Aug 9, 2023

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Aug 9, 2023

Uh oh!

rushatgabhane commented Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane commented Aug 9, 2023

Uh oh!

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

perunt commented Aug 9, 2023

Uh oh!

shawnborton commented Aug 9, 2023

Uh oh!

stitesExpensify left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

perunt commented Aug 9, 2023

Uh oh!

shawnborton commented Aug 9, 2023

Uh oh!

stitesExpensify commented Aug 9, 2023

Uh oh!

stitesExpensify commented Aug 9, 2023

Uh oh!

perunt commented Aug 10, 2023

Uh oh!

stitesExpensify commented Aug 10, 2023

Uh oh!

stitesExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

perunt commented Aug 11, 2023

Uh oh!

stitesExpensify commented Aug 11, 2023

Uh oh!

stitesExpensify commented Aug 11, 2023

Uh oh!

OSBotify commented Aug 11, 2023

Uh oh!

OSBotify commented Aug 14, 2023

Uh oh!

OSBotify commented Aug 14, 2023

Uh oh!

JmillsExpensify commented Aug 16, 2023

Uh oh!

stitesExpensify commented Aug 16, 2023

Uh oh!

OSBotify commented Aug 17, 2023

Uh oh!

JmillsExpensify commented Aug 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

perunt commented Aug 9, 2023 •

edited

Loading

rushatgabhane commented Aug 9, 2023 •

edited

Loading

stitesExpensify left a comment •

edited

Loading