Fix Tooltip content only have comma in content when hovering group chat with non-register users by hoangzinh · Pull Request #23807 · Expensify/App

hoangzinh · 2023-07-28T17:04:31Z

Details

Fixed Issues

$ #22593
PROPOSAL: #22593 (comment)

Tests

On Web/Desktop

Create a new group chat with non-register users (For example a group with 4 non-register users userA, userB, userC, userD)
Go to Search page, search the group and hover the subscript avatar of the group chat.
Verify that Tooltip content should have the user email
Verify that in the Search page, it's not show options for 4 non-register users above.

On mweb/Native apps

Create a new group chat with non-register users (For example a group with 4 non-register users userA, userB, userC, userD)
Go to Search page, search the group and hover the subscript avatar of the group chat.
Verify that in the Search page, it's not show options for 4 non-register users above.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-31.at.23.31.47.-.web.mov

Mobile Web - Chrome

Screen.Recording.2023-07-31.at.23.42.39.-.android.chrome.mov

Mobile Web - Safari

Screen.Recording.2023-07-31.at.23.40.45.-.ios.safari.mov

Desktop

Screen.Recording.2023-07-31.at.23.34.46.-.desktop.mov

iOS

Screen.Recording.2023-07-31.at.23.39.12.-.ios.mov

Android

Screen.Recording.2023-07-31.at.23.41.44.-.android.mov

melvin-bot · 2023-07-31T16:44:17Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-08-01T07:36:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-01.at.13.30.29.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

rushatgabhane

LGTM

melvin-bot · 2023-08-01T08:17:10Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #22593 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

hoangzinh · 2023-08-09T04:51:47Z

cc @Beamanator for code review ^

Beamanator · 2023-08-09T07:32:04Z

Sorry I'd like to know what the HOLD was for in the issue before moving forward with this, also before we officially move forward we should definitely pull main here & re-test, but let's hold off till we know if we need these changes now still

hoangzinh · 2023-08-18T17:45:23Z

bump @Beamanator to review this PR.

Beamanator

looks good to me, will leave for @jasperhuangg

jasperhuangg · 2023-08-23T18:16:19Z

+    // We're only picking personal details that have logins set
+    // This is a temporary fix for all the logic that's been breaking because of the new privacy changes
+    // See https://github.com/Expensify/Expensify/issues/293465 for more context


Maybe add to this comment a bit explaining the placement of this block specifically–like why do we need to put it after the logic where we generate all the report options?

Hi @jasperhuangg I'm unsure should we add more comment about placement of this block. Because the current comment is quite clear to me. It's saying we should only pick ... because ...

But I just added a comment about why we should not override personalDetails object. Could you help to review the comment again? Thanks

OSBotify · 2023-08-24T18:32:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-28T18:50:26Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:19:29Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.58-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-30T01:57:57Z

🚀 Deployed to staging by https://github.com/jasperhuangg in version: 1.3.59-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:58:15Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Only filter personal details having login for displaying in option list

89414f6

hoangzinh marked this pull request as ready for review July 31, 2023 16:44

hoangzinh requested a review from a team as a code owner July 31, 2023 16:44

melvin-bot Bot requested review from rushatgabhane and removed request for a team July 31, 2023 16:44

hoangzinh mentioned this pull request Jul 31, 2023

[HOLD for payment 2023-09-06] [$1000] Tooltip content only have comma in content when hovering group chat with non-register users #22593

Closed

6 tasks

rushatgabhane approved these changes Aug 1, 2023

View reviewed changes

melvin-bot Bot requested a review from Beamanator August 1, 2023 08:17

Merge branch 'main' into df/22593

ca33a26

rushatgabhane approved these changes Aug 23, 2023

View reviewed changes

melvin-bot Bot requested a review from jasperhuangg August 23, 2023 08:19

Beamanator previously approved these changes Aug 23, 2023

View reviewed changes

jasperhuangg requested changes Aug 23, 2023

View reviewed changes

Add more comment to warning override personalDetails object

5828a1d

hoangzinh dismissed Beamanator’s stale review via 5828a1d August 24, 2023 17:06

jasperhuangg approved these changes Aug 24, 2023

View reviewed changes

jasperhuangg merged commit 53c4743 into Expensify:main Aug 24, 2023

OSBotify mentioned this pull request Aug 28, 2023

Deploy Checklist: New Expensify 2023-08-28 #26113

Closed

OSBotify mentioned this pull request Aug 30, 2023

Deploy Checklist: New Expensify 2023-08-30 #26268

Closed

Uh oh!

Conversation

hoangzinh commented Jul 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 31, 2023

Uh oh!

rushatgabhane commented Aug 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

rushatgabhane left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Aug 1, 2023

Uh oh!

hoangzinh commented Aug 9, 2023

Uh oh!

Beamanator commented Aug 9, 2023

Uh oh!

hoangzinh commented Aug 18, 2023

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

jasperhuangg Aug 23, 2023

Choose a reason for hiding this comment

Uh oh!

hoangzinh Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 24, 2023

Uh oh!

OSBotify commented Aug 28, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 30, 2023

Uh oh!

OSBotify commented Aug 31, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hoangzinh commented Jul 28, 2023 •

edited

Loading

rushatgabhane commented Aug 1, 2023 •

edited

Loading

hoangzinh Aug 24, 2023 •

edited

Loading