use getIconsForParticipants for icons in getAssignee in Task by c3024 · Pull Request #23773 · Expensify/App

c3024 · 2023-07-28T02:35:29Z

Details

Task assignee tooltip does not show displayName. This is corrected by fetching icons correctly to include accountID in the icons object.

Fixed Issues

$ #23632
PROPOSAL: #23632 (comment)

Tests

Click FAB and click on assign task
Give a task name and click next.
Select an assignee with a display name different from their login
Hover on the avatar to see that display name is visible

Verify that no errors appear in the JS console

Offline tests

Click FAB and click on assign task
Give a task name and click next.
Select an assignee with a display name different from their login
Hover on the avatar to see that display name is visible

QA Steps

Click FAB and click on assign task
Give a task name and click next.
Select an assignee with a display name different from their login
Hover on the avatar to see that display name is visible

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

webChrome-icons.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop-icons.mov

iOS

Android

melvin-bot · 2023-07-28T02:35:34Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel

Lets clean this up, thanks!

Santhosh-Sellavel · 2023-07-28T21:19:53Z

                return setErrorMessage(props.translate('task.assigneeError'));
            }
-            const displayDetails = Task.getAssignee(assigneeDetails);
+            const displayDetails = Task.getAssignee(assigneeDetails, props.personalDetails);


We are doing something unnecessary computing for assigneeDetails let's remove that here.
And just pass assigneeAccountID & personalDetails for the getAssignee method

Yes. Changed to passing assigneeAccountID and removed assigneeDetails lines. These lines are in props.task.assignee is true so assigneeDetails will never be falsy here, and the error returning line can be safely removed.

Santhosh-Sellavel · 2023-07-28T21:23:24Z

+function getAssignee(details, personalDetails) {
    if (!details) {


Here we can get params assigneeAccountID instead of details & personalDetails.

Compute details here like this

details = personalDetails[assigneeAccountID];

c3024 · 2023-07-29T02:14:34Z

Thanks @Santhosh-Sellavel . Cleaned it up!

c3024 · 2023-07-31T15:35:50Z

Bump!! @Santhosh-Sellavel

Santhosh-Sellavel · 2023-07-31T19:49:18Z

 * Get the assignee data
 *
- * @param {Object} details
+ * @param {string} assigneeAccountID


It's Number I guess, can you confirm thanks!

It's number, please address this otherwise we are good to go here.

Santhosh-Sellavel · 2023-07-31T20:30:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-08-01.at.1.45.42.AM.mov

Mobile Web - Chrome

Mobile Web - Safari

iOS

Android

Santhosh-Sellavel

Mostly looks good just one minor docs change

Santhosh-Sellavel · 2023-07-31T20:27:01Z

 * Get the assignee data
 *
- * @param {Object} details
+ * @param {string} assigneeAccountID


It's number, please address this otherwise we are good to go here.

c3024 · 2023-07-31T21:42:32Z

Pardon my oversight. Fixed it. Thank you @Santhosh-Sellavel .

Santhosh-Sellavel

Thanks, LGTM!

C+ Reviewed!

OSBotify · 2023-08-01T17:14:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-02T01:22:00Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T17:43:13Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.50-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T18:14:27Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-07T18:31:33Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.50-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

c3024 requested a review from a team as a code owner July 28, 2023 02:35

melvin-bot Bot removed the request for review from a team July 28, 2023 02:35

melvin-bot Bot requested a review from Santhosh-Sellavel July 28, 2023 02:35

c3024 added 2 commits July 28, 2023 08:30

use getIconsForParticipants for assignee in task

6d414cd

add JSDoc personalDetails to getAssignee

b1bd27e

c3024 force-pushed the 23632-show-displayName-in-assignee-in-Task-page branch from 072665d to b1bd27e Compare July 28, 2023 03:07

c3024 mentioned this pull request Jul 28, 2023

[HOLD for payment 2023-08-10] [$1000] Web - Task - Assignee tooltip does not show display name, but 'Share somewhere' tooltip does #23632

Closed

6 tasks

Santhosh-Sellavel suggested changes Jul 28, 2023

View reviewed changes

use assigneeAccountID at details for getAssignee

fc1929e

Santhosh-Sellavel reviewed Jul 31, 2023

View reviewed changes

change param to Number in doc for getAssignee

bbdece4

Santhosh-Sellavel approved these changes Aug 1, 2023

View reviewed changes

melvin-bot Bot requested a review from thienlnam August 1, 2023 16:47

thienlnam approved these changes Aug 1, 2023

View reviewed changes

thienlnam merged commit a750097 into Expensify:main Aug 1, 2023

Santhosh-Sellavel mentioned this pull request Aug 1, 2023

Allow optimistic assignee chat reports #22778

Merged

58 tasks

OSBotify mentioned this pull request Aug 1, 2023

Deploy Checklist: New Expensify 2023-08-01 #24028

Closed

79 tasks

OSBotify mentioned this pull request Aug 3, 2023

Deploy Checklist: New Expensify 2023-08-03 #24121

Closed

86 tasks

b4s36t4 mentioned this pull request Aug 22, 2023

[HOLD E/E #311912] [$500] Assignee does not show on Confirm task page #25680

Closed

6 tasks

		function getAssignee(details, personalDetails) {
		if (!details) {

Conversation

c3024 commented Jul 28, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 28, 2023

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

c3024 Jul 29, 2023

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

c3024 Jul 29, 2023

Choose a reason for hiding this comment

Uh oh!

c3024 commented Jul 29, 2023

Uh oh!

c3024 commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Santhosh-Sellavel Jul 31, 2023

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel Jul 31, 2023

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel Jul 31, 2023

Choose a reason for hiding this comment

Uh oh!

c3024 commented Jul 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 1, 2023

Uh oh!

OSBotify commented Aug 2, 2023

Uh oh!

OSBotify commented Aug 3, 2023

Uh oh!

OSBotify commented Aug 3, 2023

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

c3024 commented Jul 31, 2023 •

edited

Loading

Santhosh-Sellavel commented Jul 31, 2023 •

edited

Loading

c3024 commented Jul 31, 2023 •

edited

Loading