Skip to content

[NoQA] Fix: console warning by making innerRef optional to PressableWithDelayToggle #23717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joelbettner merged 5 commits into from
Aug 3, 2023
Merged

[NoQA] Fix: console warning by making innerRef optional to PressableWithDelayToggle #23717

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
074915d
fix: PressableWithDelayToggle innerRef optional
jayeshmangwani Jul 27, 2023
ca9cf8c
Merge branch 'main' into make_PressableWithDelayToggle_innerRef_optional
jayeshmangwani Jul 31, 2023
2b387de
Merge branch 'main' into make_PressableWithDelayToggle_innerRef_optional
jayeshmangwani Jul 31, 2023
50231a6
Merge branch 'main' into make_PressableWithDelayToggle_innerRef_optional
jayeshmangwani Aug 1, 2023
f1b43f5
Merge branch 'main' into make_PressableWithDelayToggle_innerRef_optional
jayeshmangwani Aug 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/Pressable/PressableWithDelayToggle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import useThrottledButtonState from '../../hooks/useThrottledButtonState';

const propTypes = {
/** Ref passed to the component by React.forwardRef (do not pass from parent) */
innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]).isRequired,
innerRef: PropTypes.oneOfType([PropTypes.func, PropTypes.shape({current: PropTypes.instanceOf(React.Component)})]),

@rushatgabhane rushatgabhane Aug 1, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayeshmangwani could you please help me understand in which case React.forwardRef won't pass a ref?

@jayeshmangwani jayeshmangwani Aug 2, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rushatgabhane Yes sure, the CopyTextToClipboard component uses the PressableWithDelayToggle Component as a child. And here, no ref passed to the PressableWithDelayToggle from CopyTextToClipboard so that the child component is getting the null value for innerRef And React.forwardRef will pass null value to ref

App/src/components/CopyTextToClipboard.js

Lines 23 to 32 in 6a38341

function CopyTextToClipboard(props) {
const copyToClipboard = useCallback(() => {
Clipboard.setString(props.text);
}, [props.text]);
return (
<PressableWithDelayToggle
text={props.text}
tooltipText={props.translate('reportActionContextMenu.copyToClipboard')}
tooltipTextChecked={props.translate('reportActionContextMenu.copied')}

@rushatgabhane rushatgabhane Aug 3, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!


/** The text to display */
text: PropTypes.string,
Expand Down Expand Up @@ -67,6 +67,7 @@ const defaultProps = {
icon: null,
inline: true,
iconChecked: Expensicons.Checkmark,
innerRef: () => {},
};

function PressableWithDelayToggle(props) {
Expand Down