Skip to content

Workspace tooltip #23527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 4 commits into from
Aug 2, 2023
Merged

Workspace tooltip #23527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f1ed608
Workspace tooltip
Nodebrute Jul 24, 2023
1000cb9
update default values
Nodebrute Jul 25, 2023
55af856
Merge branch 'Expensify:main' into workspaceTooltip
Nodebrute Jul 27, 2023
67ab9f7
avatar fix
Nodebrute Jul 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/pages/home/report/ReportActionItemFragment.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import CONST from '../../../CONST';
import applyStrikethrough from '../../../components/HTMLEngineProvider/applyStrikethrough';
import editedLabelStyles from '../../../styles/editedLabelStyles';
import UserDetailsTooltip from '../../../components/UserDetailsTooltip';
import avatarPropTypes from '../../../components/avatarPropTypes';

const propTypes = {
/** Users accountID */
Expand Down Expand Up @@ -60,6 +61,9 @@ const propTypes = {
/** The accountID of the copilot who took this action on behalf of the user */
delegateAccountID: PropTypes.number,

/** icon */
actorIcon: avatarPropTypes,

...windowDimensionsPropTypes,

/** localization props */
Expand All @@ -79,6 +83,7 @@ const defaultProps = {
source: '',
style: [],
delegateAccountID: 0,
actorIcon: {},
};

function ReportActionItemFragment(props) {
Expand Down Expand Up @@ -152,6 +157,7 @@ function ReportActionItemFragment(props) {
<UserDetailsTooltip
accountID={props.accountID}
delegateAccountID={props.delegateAccountID}
icon={props.actorIcon}
>
<Text
numberOfLines={props.isSingleLine ? 1 : undefined}
Expand Down
1 change: 1 addition & 0 deletions src/pages/home/report/ReportActionItemSingle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,7 @@ function ReportActionItemSingle(props) {
isLoading={props.action.isLoading}
delegateAccountID={props.action.delegateAccountID}
isSingleLine
actorIcon={icon}
/>
))}
</PressableWithoutFeedback>
Expand Down