Skip to content

Fix Share somewhere in assign task shows a wrong report #23338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertjchen merged 2 commits into from
Jul 24, 2023
Merged

Fix Share somewhere in assign task shows a wrong report #23338

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
72c999e
filter out task, money request, chat room, and policy expense report
bernhardoj Jul 21, 2023
0783509
fix typo
bernhardoj Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions src/libs/ReportUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2183,20 +2183,28 @@ function shouldReportBeInOptionList(report, currentReportId, isInGSDMode, iouRep
}

/**
* Attempts to find a report in onyx with the provided list of participants. Does not include threads
* Attempts to find a report in onyx with the provided list of participants. Does not include threads, task, money request, room, and policy expense chat.
* @param {Array<Number>} newParticipantList
* @returns {Array|undefined}
*/
function getChatByParticipants(newParticipantList) {
newParticipantList.sort();
return _.find(allReports, (report) => {
// If the report has been deleted, or there are no participants (like an empty #admins room) then skip it
if (!report || _.isEmpty(report.participantAccountIDs) || isChatThread(report)) {
if (
!report ||
_.isEmpty(report.participantAccountIDs) ||
isChatThread(report) ||
isTaskReport(report) ||
isMoneyRequestReport(report) ||
isChatRoom(report) ||
isPolicyExpenseChat(report)
) {
return false;
}

// Only return the room if it has all the participants and is not a policy room
return !isUserCreatedPolicyRoom(report) && _.isEqual(newParticipantList, _.sortBy(report.participantAccountIDs));
// Only return the chat if it has all the participants
return _.isEqual(newParticipantList, _.sortBy(report.participantAccountIDs));
});

@bernhardoj bernhardoj Jul 21, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isUserCreatedPolicyRoom is included in isChatRoom

}

Expand Down