Skip to content

Remove unnecessary default value #23206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasperhuangg merged 1 commit into from
Jul 19, 2023
Merged

Remove unnecessary default value #23206

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/ReportActionsUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ function hasCommentThread(reportAction) {
* @param {Object} [allReportActionsParam]
* @returns {Object}
*/
function getParentReportAction(report, allReportActionsParam = {}) {
function getParentReportAction(report, allReportActionsParam) {

@luacmartins luacmartins Jul 19, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This param is optional, so it'd be better to do allReportActionsParam = undefined, like we do in a few other places, e.g.

App/.github/libs/ActionUtils.js

Line 28 in 450573e

function getStringInput(name, options, defaultValue = undefined) {

@aldo-expensify aldo-expensify Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh good point

@aldo-expensify aldo-expensify Jul 19, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about that, but then I thought it would be equivalent, is it not?

@luacmartins luacmartins Jul 19, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is, it's just more explicit.

if (!report || !report.parentReportID || !report.parentReportActionID) {
return {};
}
Expand Down