Setup the compose focus manager on screen focus by bernhardoj · Pull Request #23181 · Expensify/App

bernhardoj · 2023-07-19T16:58:34Z

Details

Currently, ReportActionComposeFocusManager is set up only on the component mount. The focus manager is a global listener that is attached to every report screen. When the focus manager is clear by component (report screen) unmount, it won't work anymore. So, this PR set up the focus manager every time a report screen is focused.

Fixed Issues

$ #21739
PROPOSAL: #21739 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Prerequisite: have a group chat
Web/Desktop

Open a group chat and verify the composer is auto focused
Right-click the group chat in LHN and click Mark as unread and wait for the popover to close
Verify the composer is focused
Click the group chat header to open the participant list
Select any participant and click Message {user name}
Verify the composer is focused
Go back by pressing the browser back button (for Desktop, go to the app top toolbar History > Back)
Verify the composer is focused
Repeat steps 2 and 3

Android/iOS/mWeb
This is web/desktop issue only

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-20.at.00.37.54.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2023-07-20.at.00.42.23.mov

iOS

Android

melvin-bot · 2023-07-19T16:58:39Z

@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-07-19T17:01:57Z

+        this.unsubscribeNavigationFocus = this.props.navigation.addListener('focus', () => {
+            KeyDownListener.addKeyDownPressListner(this.focusComposerOnKeyPress);
+            this.setUpComposeFocusManager();
+        });


Calling this.setUpComposeFocusManager() in focus listener as we are already using it. focus is triggered on screen focus only, not on mount. If we later migrate to functional component, we can use useFocusEffect only.

Btw, do you think we should clear the listener on screen blur? I don't see any reason we want to focus the composer while the report screen is not focused.

I think so. It's redundant.

aimane-chnaif · 2023-07-21T07:03:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

aimane-chnaif

LGTM 🎉

OSBotify · 2023-07-24T15:16:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-25T01:43:21Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:52:52Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

setup the compose focus manager on screen focus

08dd70b

bernhardoj requested a review from a team as a code owner July 19, 2023 16:58

melvin-bot Bot requested review from aimane-chnaif and removed request for a team July 19, 2023 16:58

bernhardoj commented Jul 19, 2023

View reviewed changes

fix lint

c7e737a

aimane-chnaif approved these changes Jul 21, 2023

View reviewed changes

melvin-bot Bot requested a review from grgia July 21, 2023 07:03

grgia approved these changes Jul 24, 2023

View reviewed changes

grgia merged commit 9dd3a3f into Expensify:main Jul 24, 2023

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

melvin-bot Bot mentioned this pull request Jul 26, 2023

[HOLD for payment 2023-08-02] [$1000] App does not focus on compose box on mark as read/unread when we visit other profile and get back #21739

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Setup the compose focus manager on screen focus#23181

Setup the compose focus manager on screen focus#23181
grgia merged 2 commits into
Expensify:mainfrom
bernhardoj:fix/21739-composer-focus-listener

bernhardoj commented Jul 19, 2023

Uh oh!

melvin-bot Bot commented Jul 19, 2023

Uh oh!

bernhardoj Jul 19, 2023

Uh oh!

aimane-chnaif Jul 21, 2023

Uh oh!

aimane-chnaif commented Jul 21, 2023

Uh oh!

aimane-chnaif left a comment

Uh oh!

OSBotify commented Jul 24, 2023

Uh oh!

OSBotify commented Jul 25, 2023

Uh oh!

OSBotify commented Jul 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

bernhardoj commented Jul 19, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 19, 2023

Uh oh!

bernhardoj Jul 19, 2023

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif Jul 21, 2023

Choose a reason for hiding this comment

Uh oh!

aimane-chnaif commented Jul 21, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

aimane-chnaif left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Jul 24, 2023

Uh oh!

OSBotify commented Jul 25, 2023

Uh oh!

OSBotify commented Jul 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants