fix: The green line appear immediately only after comments are added to a task by dukenv0307 · Pull Request #23154 · Expensify/App

dukenv0307 · 2023-07-19T09:37:00Z

Details

The green line appear immediately only after comments are added to a task

Fixed Issues

$ #23004
PROPOSAL: #23004 (comment)

Tests

Log in with your account
Create a task
Send a message
Verify that a green line appears immediately
Send a new message and mark it as unread
Verify that the unread divider ( bold green ) appears

Verify that no errors appear in the JS console

Offline tests

QA Steps

Log in with your account
Create a task
Send a message
Verify that a green line appears immediately
Send a new message and mark it as unread
Verify that the unread divider ( bold green ) appears

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web-rmk.mp4

Mobile Web - Chrome

chrome_rmk.mp4

Mobile Web - Safari

safari_rmk.mp4

Desktop

desktop_rmk.mp4

iOS

ios_rmk.mp4

Android

android.mp4

melvin-bot · 2023-07-27T09:32:40Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-07-27T09:49:36Z

@MonilBhavsar It seems that @MelvinBot have a mistake when assigning c+ contributor to this PR
I don't know why @sobitneupane are assigned to this PR instead of @narefyev91

dukenv0307 · 2023-07-28T03:12:17Z

@MonilBhavsar Could you help to check above comment?

MonilBhavsar · 2023-07-27T11:19:04Z

                <TaskView
                    report={props.report}
-                    shouldShowHorizontalRule={!props.isOnlyReportAction}
+                    shouldShowHorizontalRule={!props.shouldHideThreadDividerLine}


In above on L427 also, shouldShowHorizontalRule prop is passed. Should we also update that?

@MonilBhavsar updated, please help review again.

MonilBhavsar · 2023-07-28T07:12:51Z

@MonilBhavsar Could you help to check above comment?

I had a look. @narefyev91 is ooo and I'll be handling this

dukenv0307 · 2023-07-31T02:27:14Z

@MonilBhavsar Bump

dukenv0307 · 2023-08-01T04:01:48Z

@MonilBhavsar ICYMI. Please help review the PR

MonilBhavsar

Thanks, looks good to me!

MonilBhavsar · 2023-08-01T10:47:20Z

@narefyev91 looks like you're back. Could you please give it a review, if fine. Thanks! 🙏

narefyev91 · 2023-08-01T11:21:30Z

@narefyev91 looks like you're back. Could you please give it a review, if fine. Thanks! 🙏

Hey - not really - will be back on Friday :-)

dukenv0307 · 2023-08-02T07:48:07Z

Hey - not really - will be back on Friday :-)

@MonilBhavsar Do we need to wait for him until Friday to give the second approval?

dukenv0307 · 2023-08-04T02:43:28Z

@narefyev91 @MonilBhavsar The PR is reviewed for the long time, Is any update on this PR

narefyev91 · 2023-08-04T06:03:57Z

@narefyev91 @MonilBhavsar The PR is reviewed for the long time, Is any update on this PR

Hey review will be done today - on it

narefyev91 · 2023-08-04T07:03:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

OSBotify · 2023-08-04T07:41:17Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-07T18:55:34Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.51-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T08:44:42Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.51-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:13:47Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-09T09:52:30Z

🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-10T20:10:56Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

dukenv0307 added 2 commits July 19, 2023 16:00

fix: The green line appear immediately only after comments are added

19b5bd9

fix: conflict

52df0e5

dukenv0307 marked this pull request as ready for review July 27, 2023 09:32

dukenv0307 requested a review from a team as a code owner July 27, 2023 09:32

melvin-bot Bot requested review from sobitneupane and removed request for a team July 27, 2023 09:32

fix: change prop

41b1164

dukenv0307 mentioned this pull request Jul 27, 2023

[HOLD for payment 2023-08-16] [$1000] Web - The green line appear immediately only after comments are added to a task #23004

Closed

6 tasks

MonilBhavsar self-requested a review July 27, 2023 11:17

MonilBhavsar reviewed Jul 28, 2023

View reviewed changes

dukenv0307 added 4 commits July 28, 2023 14:53

Merge branch 'main' into fix/23004

e3b1d13

fix: update shouldHideThreadDividerLine to moneyRequestView

bee9e09

fix: remove un-used variable

1cbebae

fix: remove redundant prop

05b22d0

merge main

e3a1e97

MonilBhavsar approved these changes Aug 1, 2023

View reviewed changes

narefyev91 approved these changes Aug 4, 2023

View reviewed changes

melvin-bot Bot requested a review from MonilBhavsar August 4, 2023 07:04

MonilBhavsar approved these changes Aug 4, 2023

View reviewed changes

MonilBhavsar merged commit c3bafa6 into Expensify:main Aug 4, 2023

OSBotify mentioned this pull request Aug 7, 2023

Deploy Checklist: New Expensify 2023-08-07 #24230

Closed

98 tasks

OSBotify mentioned this pull request Aug 9, 2023

Deploy Checklist: New Expensify 2023-08-09 #24307

Closed

87 tasks

Uh oh!

Conversation

dukenv0307 commented Jul 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 27, 2023

Uh oh!

dukenv0307 commented Jul 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Jul 28, 2023

Uh oh!

MonilBhavsar Jul 27, 2023

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Jul 28, 2023

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar commented Jul 28, 2023

Uh oh!

dukenv0307 commented Jul 31, 2023

Uh oh!

dukenv0307 commented Aug 1, 2023

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

MonilBhavsar commented Aug 1, 2023

Uh oh!

narefyev91 commented Aug 1, 2023

Uh oh!

dukenv0307 commented Aug 2, 2023

Uh oh!

dukenv0307 commented Aug 4, 2023

Uh oh!

narefyev91 commented Aug 4, 2023

Uh oh!

narefyev91 commented Aug 4, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

narefyev91 left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Aug 4, 2023

Uh oh!

OSBotify commented Aug 7, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 9, 2023

Uh oh!

OSBotify commented Aug 10, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dukenv0307 commented Jul 19, 2023 •

edited

Loading

dukenv0307 commented Jul 27, 2023 •

edited

Loading