Skip to content

[CP Staging] Fix missing settlement button #23129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 3 commits into from
Jul 18, 2023
Merged

[CP Staging] Fix missing settlement button #23129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aef0717
Add children to the header props
mountiny Jul 18, 2023
8fe414a
Make the button non-required
mountiny Jul 18, 2023
d7c1fcd
Pass default as null to the children argument
mountiny Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/components/HeaderWithBackButton/headerWithBackButtonPropTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,9 @@ const propTypes = {

/** Policies, if we're showing the details for a report and need participant details for AvatarWithDisplay */
personalDetails: PropTypes.objectOf(participantPropTypes),

/** Children to wrap in Header */
children: PropTypes.node,

@luacmartins luacmartins Jul 18, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if defining children in the propTypes here will conflict with this declaration

@luacmartins luacmartins Jul 18, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, children is not required but we're not setting a default value for it

@mountiny mountiny Jul 18, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making it required has been complaining in the logs as some usecases were not passing children I think

};

export default propTypes;
2 changes: 2 additions & 0 deletions src/components/HeaderWithBackButton/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ function HeaderWithBackButton({
horizontal: 0,
},
threeDotsMenuItems = [],
children = null,
}) {
const [isDownloadButtonActive, temporarilyDisableDownloadButton] = useThrottledButtonState();
const {translate} = useLocalize();
Expand Down Expand Up @@ -93,6 +94,7 @@ function HeaderWithBackButton({
/>
)}
<View style={[styles.reportOptions, styles.flexRow, styles.pr5, styles.alignItemsCenter]}>
{children}
{shouldShowDownloadButton && (
<Tooltip text={translate('common.download')}>
<PressableWithoutFeedback
Expand Down