Skip to content

fix: dismiss create new room page if user has no workspaces #22866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuwenmemon merged 2 commits into from
Jul 14, 2023
Merged

fix: dismiss create new room page if user has no workspaces #22866

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c1fb00
fix: dismiss new room modal if no workspaces
GItGudRatio Jul 14, 2023
02a8612
fix: avoid keyboard flickering
GItGudRatio Jul 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pages/workspace/WorkspaceNewRoomPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,14 @@ function WorkspaceNewRoomPage(props) {
);

useEffect(() => {
if (Permissions.canUsePolicyRooms(props.betas)) {
if (Permissions.canUsePolicyRooms(props.betas) && workspaceOptions.length) {
return;
}
Log.info('Not showing create Policy Room page since user is not on policy rooms beta');
Navigation.dismissModal();
}, [props.betas]);
}, [props.betas, workspaceOptions]);

if (!Permissions.canUsePolicyRooms(props.betas)) {
if (!Permissions.canUsePolicyRooms(props.betas) || !workspaceOptions.length) {

@GItGudRatio GItGudRatio Jul 14, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this to avoid an issue in native devices where, a small keyboard flickering issue can be seen when clicking on the link. Here's a visual sample of the bug:

2023-07-14.12-17-15.mp4

return null;
}

Expand Down