Skip to content

Don't change loading state on resend magic code #22564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grgia merged 1 commit into from
Jul 13, 2023
Merged

Don't change loading state on resend magic code #22564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 1 addition & 23 deletions src/libs/actions/Session/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,33 +170,11 @@ function resendValidateCode(login = credentials.login) {
onyxMethod: Onyx.METHOD.MERGE,
key: ONYXKEYS.ACCOUNT,
value: {
isLoading: true,
errors: null,
loadingForm: CONST.FORMS.VALIDATE_CODE_FORM,
},
},
];
const successData = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: ONYXKEYS.ACCOUNT,
value: {
isLoading: false,
loadingForm: null,
},
},
];
const failureData = [
{
onyxMethod: Onyx.METHOD.MERGE,
key: ONYXKEYS.ACCOUNT,
value: {
isLoading: false,
loadingForm: null,
},

@grgia grgia Jul 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reasoning for removing these entirely versus copying the changes to each?

@bernhardoj bernhardoj Jul 12, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to show any loading indicator when resending a new magic code, so both success and failure data is not needed since we don't change the loading state (isLoading and loadingForm)

@aimane-chnaif aimane-chnaif Jul 14, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit late but loadingForm is still needed to fix #21293.
Only isLoading can be removed here.

},
];
API.write('RequestNewValidateCode', {email: login}, {optimisticData, successData, failureData});
API.write('RequestNewValidateCode', {email: login}, {optimisticData});
}

/**
Expand Down