Migrate/workspacelistpage issue/16310 by code0406 · Pull Request #22248 · Expensify/App

code0406 · 2023-07-05T07:55:08Z

Details

Migrated WorkspaceListPage.js to function component.
And used useMemo to improve the performance.

Fixed Issues

$ #16310
PROPOSAL: #16310 (comment)

Tests

We can test the "Workspaces" page where the workspace list is placed.
Then how to open the page.

Click the "Settings" button.
Click the "Workspaces" menu on the "Settings" page.
Verify if there are workspaces in the list. It may be empty if there is not any workspace.

Verify that no errors appear in the JS console

Offline tests

We can test the "Workspaces" page where the workspace list is placed.
Then how to open the page.

Click the "Settings" button.
Click the "Workspaces" menu on the "Settings" page.
Verify if there are workspaces in the list. It may be empty if there is not any workspace.

QA Steps

We can test the "Workspaces" page where the workspace list is placed.
Then how to open the page.

Click the "Settings" button.
Click the "Workspaces" menu on the "Settings" page.
Verify if there are workspaces in the list. It may be empty if there is not any workspace.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

iphone-web.mov

Desktop

desktop.mov

iOS

iphone.mov

Android

android.mov

melvin-bot · 2023-07-05T07:55:13Z

@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2023-07-05T07:55:28Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

github-actions · 2023-07-05T07:55:28Z

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request}

code0406 · 2023-07-05T07:59:29Z

I have read the CLA Document and I hereby sign the CLA

0xmiroslav · 2023-07-15T03:27:25Z

+    return (
+        <ScreenWrapper>
+            <HeaderWithBackButton
+                title={translate('common.workspaces')}


NAB: There's already useLocalize hook for function component but this is not standardized yet and many function components are still using withLocalize HOC. Maybe one day we need to replace all withLocalize occurrences with useLocalize.

I know we haven't officially discussed this in slack but I've been asking everyone to use the hooks going forward.

0xmiroslav · 2023-07-15T03:37:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop.mov

iOS

Android

0xmiroslav

LGTM!

hayata-suenaga

👍

hayata-suenaga · 2023-07-17T21:49:23Z

@code0406 can you sign the CLA?

0xmiroslav · 2023-07-18T02:56:40Z

It's strange. They already signed and bot recognized it

roryabraham · 2023-07-18T03:26:44Z

I retried the CLA workflow and it succeeded, merging this to prevent conflicts with a PR I'm about to start working on 👍🏼

OSBotify · 2023-07-18T04:08:31Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.42-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-19T17:59:08Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-21T18:53:54Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:27:51Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

code0406 added 3 commits July 4, 2023 08:47

migrated to function component

a6525fe

fixed eslint

92e7007

useMemo to improve the performance

ef8fcb9

code0406 requested a review from a team as a code owner July 5, 2023 07:55

melvin-bot Bot requested review from 0xmiroslav and removed request for a team July 5, 2023 07:55

0xmiroslav reviewed Jul 15, 2023

View reviewed changes

0xmiroslav approved these changes Jul 15, 2023

View reviewed changes

melvin-bot Bot requested a review from hayata-suenaga July 15, 2023 03:37

hayata-suenaga reviewed Jul 17, 2023

View reviewed changes

Comment thread src/pages/workspace/WorkspacesListPage.js

hayata-suenaga approved these changes Jul 17, 2023

View reviewed changes

roryabraham merged commit 72bb2a2 into Expensify:main Jul 18, 2023

OSBotify mentioned this pull request Jul 18, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

melvin-bot Bot mentioned this pull request Jul 19, 2023

[HOLD for payment 2023-07-26] [$250] Migrate WorkspacesListPage.js to function component #16310

Closed

1 task

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

Uh oh!

Conversation

code0406 commented Jul 5, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 5, 2023

Uh oh!

github-actions Bot commented Jul 5, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 5, 2023

Uh oh!

code0406 commented Jul 5, 2023

Uh oh!

0xmiroslav Jul 15, 2023

Choose a reason for hiding this comment

Uh oh!

roryabraham Jul 18, 2023

Choose a reason for hiding this comment

Uh oh!

0xmiroslav commented Jul 15, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

0xmiroslav left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hayata-suenaga left a comment

Choose a reason for hiding this comment

Uh oh!

hayata-suenaga commented Jul 17, 2023

Uh oh!

0xmiroslav commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roryabraham commented Jul 18, 2023

Uh oh!

OSBotify commented Jul 18, 2023

Uh oh!

OSBotify commented Jul 19, 2023

Uh oh!

OSBotify commented Jul 21, 2023

Uh oh!

OSBotify commented Jul 25, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Jul 5, 2023 •

edited

Loading

0xmiroslav commented Jul 18, 2023 •

edited

Loading