Skip to content

fix: disable the default callout in ios safari #22216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hayata-suenaga merged 10 commits into from
Jul 24, 2023
Merged

fix: disable the default callout in ios safari #22216

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e6b3973
fix: disable the default callout in ios safari
sangar-1028 Jul 4, 2023
bcce9eb
fix: remove ios native warning
sangar-1028 Jul 4, 2023
e7046bc
Merge branch 'main' into fix/issue-21344
sangar-1028 Jul 6, 2023
a746529
fix: remove web warnings
sangar-1028 Jul 6, 2023
bc10582
fix: refine code
sangar-1028 Jul 8, 2023
5aa8c12
Merge branch 'main' into fix/issue-21344
sangar-1028 Jul 8, 2023
c6c204e
fix: conflicts resolved
sangar-1028 Jul 12, 2023
9ac06f0
Merge branch 'main' into fix/issue-21344
sangar-1028 Jul 13, 2023
7dd56ee
Merge branch 'main' into fix/issue-21344
sangar-1028 Jul 13, 2023
27dc7f4
fix: add comments for touch callout
sangar-1028 Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/styles/styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,14 @@ import pointerEventsAuto from './pointerEventsAuto';
import getPopOverVerticalOffset from './getPopOverVerticalOffset';
import overflowXHidden from './overflowXHidden';
import CONST from '../CONST';
import * as Browser from '../libs/Browser';
import cursor from './utilities/cursor';
import userSelect from './utilities/userSelect';
import textUnderline from './utilities/textUnderline';

// touchCallout is an iOS safari only property that controls the display of the callout information when you touch and hold a target
const touchCalloutNone = Browser.isMobileSafari() ? {WebkitTouchCallout: 'none'} : {};
Comment thread
dummy-1111 marked this conversation as resolved.
Comment thread
dummy-1111 marked this conversation as resolved.

const picker = {
backgroundColor: themeColors.transparent,
color: themeColors.text,
Expand Down Expand Up @@ -129,6 +133,7 @@ const webViewStyles = {
borderColor: themeColors.border,
borderRadius: variables.componentBorderRadiusNormal,
borderWidth: 1,
...touchCalloutNone,
},

p: {
Expand Down