[Fix] OptionListUtils.getOptions is filtering workspaces chats by fedirjh · Pull Request #21357 · Expensify/App

fedirjh · 2023-06-22T21:44:58Z

Details

In this PR we are fixing a bug where the OptionListUtils.getOptions filters the workspace chats , the root cause is that we are passing invalid number of arguments to ReportUtils.shouldReportBeInOptionLis in this line

ReportUtils.shouldReportBeInOptionList is used to check if the chat should be in the optionList, passing invalid arguments will make the function returns false regardless of the beta access in this line , since we are passing invalid number of arguments , the betas argument is holding a different value instead of the betas, resulting in Permissions.canUsePolicyExpenseChat returning false.

Fixed Issues

$ #21313
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Update Permissions.js -> canUsePolicyExpenseChat to make it consistent with other environments :

function canUsePolicyExpenseChat(betas) {
    return _.contains(betas, CONST.BETAS.POLICY_EXPENSE_CHAT);
}

Login as a new user who does have a workspace with policy expense beta
Verify the you can see in the LHN a Workspace Chat
Run through the following flows and verify...
Search -> Workspace Chat appear
LHN -> Workspace Chat appear
Request money -> Workspace Chat
New chat -> None
New group -> None
Send money -> None
Split bill -> None

Verify that no errors appear in the JS console

Offline tests

Same test

QA Steps

Login as a new user who does have a workspace with policy expense beta
Verify the you can see in the LHN a Workspace Chat
Run through the following flows and verify...
Search -> Workspace Chat appear
LHN -> Workspace Chat appear
Request money -> Workspace Chat
New chat -> None
New group -> None
Send money -> None
Split bill -> None

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[Fix] use accountID instead of login [Fix] test revert changes revert changes [Fix] Invalid number of arguments

fedirjh · 2023-06-23T18:21:23Z

-    const filteredReports = _.filter(reports, (report) =>
-        ReportUtils.shouldReportBeInOptionList(report, Navigation.getReportIDFromRoute(), false, currentUserLogin, iouReports, betas, policies),
-    );
+    const filteredReports = _.filter(reports, (report) => ReportUtils.shouldReportBeInOptionList(report, Navigation.getReportIDFromRoute(), false, iouReports, betas, policies));


I just removed the extra argument currentUserLogin

melvin-bot · 2023-06-23T18:26:20Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

narefyev91 · 2023-06-26T07:21:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

narefyev91

LGTM!
🎀 👀 🎀 C+ reviewed

melvin-bot · 2023-06-26T11:06:19Z

We did not find an internal engineer to review this PR, trying to assign a random engineer to #21313... Please reach out for help on Slack if no one gets assigned!

OSBotify · 2023-06-26T16:23:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-26T21:06:22Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.33-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

kbecciv · 2023-06-27T16:32:13Z

@fedirjh Can you please confirm if we should test this PR on gmail account on step1. Login as a new user who does have a workspace with policy expense beta? Thank you

fedirjh · 2023-06-27T16:42:29Z

Can you please confirm if we should test this PR on gmail account on step1.

@kbecciv expensifail account should be feasible, I think all expensifail have access to all betas including the policy expense.

OSBotify · 2023-06-28T14:06:46Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.33-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[Fix] Invalid number of arguments

af27f77

[Fix] use accountID instead of login [Fix] test revert changes revert changes [Fix] Invalid number of arguments

fedirjh force-pushed the Fix-OptionListUtils branch from e59d87b to af27f77 Compare June 23, 2023 18:15

fedirjh commented Jun 23, 2023

View reviewed changes

fedirjh marked this pull request as ready for review June 23, 2023 18:26

fedirjh requested a review from a team as a code owner June 23, 2023 18:26

melvin-bot Bot requested review from narefyev91 and removed request for a team June 23, 2023 18:26

narefyev91 approved these changes Jun 26, 2023

View reviewed changes

AndrewGable self-requested a review June 26, 2023 16:13

AndrewGable approved these changes Jun 26, 2023

View reviewed changes

AndrewGable merged commit 3a45fcb into Expensify:main Jun 26, 2023

fedirjh deleted the Fix-OptionListUtils branch June 26, 2023 16:24

anmurali mentioned this pull request Jun 26, 2023

[HOLD for payment 2023-06-23] [$250] [Accessible Pressables] Migrate WorkspaceInviteMessagePage to accessible pressables #20607

Closed

OSBotify mentioned this pull request Jun 26, 2023

Deploy Checklist: New Expensify 2023-06-26 #21650

Closed

23 tasks

melvin-bot Bot mentioned this pull request Jun 28, 2023

[HOLD for payment 2023-07-05] [$1000] Workspace Chat (policyExpenseChat) not appearing in the OptionsList despite being on the beta #21313

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Fix] OptionListUtils.getOptions is filtering workspaces chats#21357

[Fix] OptionListUtils.getOptions is filtering workspaces chats#21357
AndrewGable merged 1 commit into
Expensify:mainfrom
fedirjh:Fix-OptionListUtils

fedirjh commented Jun 22, 2023 •

edited

Loading

Uh oh!

fedirjh Jun 23, 2023

Uh oh!

melvin-bot Bot commented Jun 23, 2023

Uh oh!

narefyev91 commented Jun 26, 2023 •

edited

Loading

Uh oh!

narefyev91 left a comment •

edited

Loading

Uh oh!

melvin-bot Bot commented Jun 26, 2023

Uh oh!

OSBotify commented Jun 26, 2023

Uh oh!

OSBotify commented Jun 26, 2023

Uh oh!

kbecciv commented Jun 27, 2023

Uh oh!

fedirjh commented Jun 27, 2023 •

edited

Loading

Uh oh!

OSBotify commented Jun 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

fedirjh commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

fedirjh Jun 23, 2023

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jun 23, 2023

Uh oh!

narefyev91 commented Jun 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

narefyev91 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Jun 26, 2023

Uh oh!

OSBotify commented Jun 26, 2023

Uh oh!

OSBotify commented Jun 26, 2023

Uh oh!

kbecciv commented Jun 27, 2023

Uh oh!

fedirjh commented Jun 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Jun 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

fedirjh commented Jun 22, 2023 •

edited

Loading

narefyev91 commented Jun 26, 2023 •

edited

Loading

narefyev91 left a comment •

edited

Loading

fedirjh commented Jun 27, 2023 •

edited

Loading