Update Referral-Program.md to show better preview and clarify the steps - #21241
Conversation
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
MonilBhavsar
left a comment
There was a problem hiding this comment.
@muttmuure Nice!
Could you please link github issue or slack thread for the context in the main github
Co-authored-by: Monil Bhavsar <monil@expensify.com>
Fixing the requested edits from Monil!
MonilBhavsar
left a comment
There was a problem hiding this comment.
Looks good 👍
I would just run it once locally to play safe.
I'm unable to and have asked for help here https://expensify.slack.com/archives/C03TQ48KC/p1687523746421999
|
Yes, sorry I was ooo for 2 days. Testing now |
Reviewer Checklist
Screenshots/VideosMobile Web - ChromeN/A Mobile Web - SafariN/ADesktopN/A iOSN/A AndroidN/A |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 1.3.34-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.34-1 🚀
|

Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/294096
Tests
Same as QA
Offline tests
N/A
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android