Fix: pencil icon disappear in LHN for announce by procrastagonist · Pull Request #20730 · Expensify/App

procrastagonist · 2023-06-13T23:08:18Z

Details

Updated ReportActionCompose component to change hasDraftComment status of Report to true if user has draft message for this report in localStorage. And updated OptionRowLHN for the same.

Fixed Issues

$ #19623
PROPOSAL: #19623 (comment)

Tests

Test 1

Open App in different browsers or use 2 tabs: incognito mode and usual one
Login with different accounts (userA and userB)
As userA, create a workspace
As userA, add userB as a member to workspace
As userB, in LHN #announce type any message in text field but don't send, just keep as a draft
As userA, remove the userB from workspace
As userB, stay on same page or click on another LHN
As userA, add userB to workspace again
As userB, check if you have pencil icon in LHN for #announce

Test 2

Open App in different browsers or use 2 tabs: incognito mode and usual one
Login with different accounts (userA and userB)
As userA, create a workspace
As userA, add userB as a member to workspace
As userB, in LHN #announce type any message in text field but don't send, just keep as a draft
As userA, remove the userB from workspace
As userB, reloads page or close tab and open webapp again
As userA, add userB to workspace again
As userB, check if you have pencil icon in LHN for #announce

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as "Tests" Section above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

screencast.mp4

Mobile Web - Chrome

web-chrome.mp4

Mobile Web - Safari

safari.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

2. Updated OptionRowLHN with validation for draft message in localstorage

github-actions · 2023-06-13T23:08:32Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

melvin-bot · 2023-06-13T23:08:52Z

@deetergp @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

procrastagonist · 2023-06-13T23:20:43Z

I have read the CLA Document and I hereby sign the CLA

mollfpr · 2023-06-14T14:53:10Z

I didn't get the time, but I will review test this in the morning.

deetergp · 2023-06-14T18:56:51Z

@mkarkachov You've got a number of unit tests failing.

mollfpr · 2023-06-15T11:43:18Z

@mkarkachov Could you resolve the jest issue so we can this out? Thanks!

…mment 2. Added ReportCommentDraftsProvider to OnyxProvider 3. Reverted previous changes in ReportActionCompose

procrastagonist · 2023-06-15T17:42:52Z

@mollfpr @deetergp Resolved, thanks! It's my 1st task so I did not figured out with whole process at once

mollfpr

Sorry for the delay, I got sick yesterday 🙏

We need to revert the podfile lock and I have question about the new Onyx context.

mollfpr

@mkarkachov Sorry to keep you waiting!

It tests well, but just couples of cleanup.

procrastagonist · 2023-06-21T15:22:32Z

@mollfpr resolved. Many thanks for reviews!

mollfpr · 2023-06-21T15:54:26Z

@mkarkachov Great! Much better now. I'll finish the test!

mollfpr · 2023-06-21T17:37:19Z

@mkarkachov I found a regression.

Steps:

Open a chat
Type some texts
Open other chat
Back to the previous chat
Delete the texts
Open other chat again

It needs several tries to reproduce it.

Screen.Recording.2023-06-22.at.01.31.17.mov

procrastagonist · 2023-06-21T19:19:02Z

@mkarkachov I found a regression.

Steps:
1. Open a chat

2. Type some texts

3. Open other chat

4. Back to the previous chat

5. Delete the texts

6. Open other chat again
It needs several tries to reproduce it.
Screen.Recording.2023-06-22.at.01.31.17.mov

Great job, thanks! Fixed

mollfpr · 2023-06-22T17:07:53Z

I applied initial proposal and started to test update. I found that:

If after step 4 of initial bug report (from UserA, remove the userB) userB reloads page or closes tab and opens webapp again later

UserB opens chat with anyone

UserA adds UserB to workspace again

Pencil icon is missed in LHN for #announce for userB even if he has draft message there

@mkarkachov Also, we should add another test for the above case.

procrastagonist · 2023-06-22T17:44:05Z

I applied initial proposal and started to test update. I found that:

If after step 4 of initial bug report (from UserA, remove the userB) userB reloads page or closes tab and opens webapp again later

UserB opens chat with anyone

UserA adds UserB to workspace again

Pencil icon is missed in LHN for #announce for userB even if he has draft message there

@mkarkachov Also, we should add another test for the above case.

@mollfpr Please clarify what do you mean? Someone should add new unit test or what?

mollfpr · 2023-06-23T08:43:16Z

I mean add the test in the PR description.

procrastagonist · 2023-06-23T10:01:25Z

I mean add the test in the PR description.

Ah, got it. Added as Test 2 to PR description. Thanks

mollfpr · 2023-06-23T13:50:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

20730.Web.mp4

Mobile Web - Chrome

20730.mWeb-Chrome.mp4

Mobile Web - Safari

20730.mWeb-Safari.mp4

Desktop

20730.Desktop.mp4

iOS

20730.iOS.mp4

Android

20730.Android.mp4

mollfpr

Thanks @mkarkachov looks great and tests well 👍

All yours @deetergp

deetergp · 2023-06-26T20:19:48Z

@mkarkachov I've approved your changes, but your PR is failing the Reassure Performance Tests. Looking at the output from the test, it looks like it has to do with changing package-lock.json, so maybe just pulling the latest main into your branch should take care of it. Let's start there.

deetergp · 2023-06-27T20:29:48Z

Never mind. I re-ran the failing test today and it passed.

OSBotify · 2023-06-27T20:33:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-28T14:27:02Z

🚀 Deployed to staging by https://github.com/deetergp in version: 1.3.34-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-29T20:28:59Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.34-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

procrastagonist added 2 commits June 13, 2023 22:40

1. Updated componentDidMount stage of ReportActionCompose component.

5cbd46e

2. Updated OptionRowLHN with validation for draft message in localstorage

Merge branch 'main' into fix/issue-19623

5b049ee

procrastagonist requested a review from a team as a code owner June 13, 2023 23:08

melvin-bot Bot requested review from deetergp and mollfpr and removed request for a team June 13, 2023 23:08

procrastagonist mentioned this pull request Jun 13, 2023

[HOLD for payment 2023-07-06] [$1000] pencil icon disappear in LHN for #announce #19623

Closed

6 tasks

procrastagonist added 4 commits June 15, 2023 17:49

1. Updated OptionRowLHN component with validation for stored draft co…

de33bbc

…mment 2. Added ReportCommentDraftsProvider to OnyxProvider 3. Reverted previous changes in ReportActionCompose

Merged with last updates in main branch and resolved merge conflicts

384a2ca

Fixed linter warnings

ba58255

Merge branch 'main' into fix/issue-19623

80e05ef

procrastagonist added 2 commits June 15, 2023 19:49

Recovered updates in ReportActionCompose

a590753

Fixed linter issue in OnyxProvider

7d2a1f7

mollfpr requested changes Jun 18, 2023

View reviewed changes

Comment thread ios/Podfile.lock Outdated

Comment thread src/components/OnyxProvider.js

mollfpr requested changes Jun 18, 2023

View reviewed changes

Comment thread src/components/LHNOptionsList/OptionRowLHN.js

Comment thread src/components/LHNOptionsList/OptionRowLHN.js Outdated

procrastagonist added 2 commits June 19, 2023 02:05

Merge branch 'main' into fix/issue-19623

b00cc8c

Reverted changes in Podfile.lock, updated useEffect in OptionRowLHN

68167d9

procrastagonist requested a review from mollfpr June 20, 2023 08:23

mollfpr requested changes Jun 21, 2023

View reviewed changes

Comment thread src/components/LHNOptionsList/OptionRowLHN.js

Comment thread src/components/LHNOptionsList/OptionRowLHN.js Outdated

procrastagonist added 2 commits June 21, 2023 17:11

Merge branch 'main' into fix/issue-19623

1de60fd

Refactored useEffect in OptionRowLHN

135b8a0

procrastagonist requested a review from mollfpr June 21, 2023 16:58

Add isMounted state to OptionRowLHN and updated useEffect logic

10d4283

mollfpr reviewed Jun 22, 2023

View reviewed changes

Comment thread src/components/LHNOptionsList/OptionRowLHN.js Outdated

Removed isMounted state

77e1f43

procrastagonist requested a review from mollfpr June 22, 2023 16:32

mollfpr requested changes Jun 22, 2023

View reviewed changes

Comment thread src/components/LHNOptionsList/OptionRowLHN.js

Comment thread src/components/LHNOptionsList/OptionRowLHN.js Outdated

Refactored useEffect in OptionRowLHN

a9dcf2d

procrastagonist requested a review from mollfpr June 22, 2023 17:48

mollfpr approved these changes Jun 23, 2023

View reviewed changes

deetergp approved these changes Jun 26, 2023

View reviewed changes

deetergp merged commit 82558a1 into Expensify:main Jun 27, 2023

OSBotify mentioned this pull request Jun 28, 2023

Deploy Checklist: New Expensify 2023-06-28 #21794

Closed

26 tasks

aimane-chnaif mentioned this pull request Oct 22, 2023

Composer - optimise rendering behaviour for onKeyPress & onSubmit #29561

Merged

58 tasks

Uh oh!

Conversation

procrastagonist commented Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions Bot commented Jun 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Jun 13, 2023

Uh oh!

procrastagonist commented Jun 13, 2023

Uh oh!

mollfpr commented Jun 14, 2023

Uh oh!

deetergp commented Jun 14, 2023

Uh oh!

mollfpr commented Jun 15, 2023

Uh oh!

procrastagonist commented Jun 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

procrastagonist commented Jun 21, 2023

Uh oh!

mollfpr commented Jun 21, 2023

Uh oh!

mollfpr commented Jun 21, 2023

Uh oh!

procrastagonist commented Jun 21, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mollfpr commented Jun 22, 2023

Uh oh!

procrastagonist commented Jun 22, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mollfpr commented Jun 23, 2023

Uh oh!

procrastagonist commented Jun 23, 2023

Uh oh!

mollfpr commented Jun 23, 2023

Reviewer Checklist

Screenshots/Videos

Uh oh!

mollfpr left a comment

Choose a reason for hiding this comment

Uh oh!

deetergp commented Jun 26, 2023

Uh oh!

deetergp commented Jun 27, 2023

Uh oh!

OSBotify commented Jun 27, 2023

Uh oh!

OSBotify commented Jun 28, 2023

Uh oh!

OSBotify commented Jun 29, 2023

Uh oh!

Reviewers

Assignees

Labels

procrastagonist commented Jun 13, 2023 •

edited

Loading

github-actions Bot commented Jun 13, 2023 •

edited

Loading

procrastagonist commented Jun 15, 2023 •

edited

Loading

procrastagonist commented Jun 22, 2023 •

edited

Loading