Skip to content

20603 — migrate ReportPreview to PressableWithoutFeedback #20712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 1 commit into from
Jun 16, 2023
+6 −4
Merged

20603 — migrate ReportPreview to PressableWithoutFeedback #20712

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/components/ReportActionItem/ReportPreview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import {View, Pressable} from 'react-native';
import {View} from 'react-native';
import PropTypes from 'prop-types';
import {withOnyx} from 'react-native-onyx';
import lodashGet from 'lodash/get';
Expand All @@ -25,6 +25,7 @@ import themeColors from '../../styles/themes/default';
import getButtonState from '../../libs/getButtonState';
import * as IOU from '../../libs/actions/IOU';
import refPropTypes from '../refPropTypes';
import PressableWithoutFeedback from '../Pressable/PressableWithoutFeedback';

const propTypes = {
/** All the data of the action */
Expand Down Expand Up @@ -103,7 +104,7 @@ const ReportPreview = (props) => {
return (
<View style={[styles.chatItemMessage]}>
{_.map(props.action.message, (message, index) => (
<Pressable
<PressableWithoutFeedback
key={`ReportPreview-${props.action.reportActionID}-${index}`}
onPress={() => {
Navigation.navigate(ROUTES.getReportRoute(props.iouReportID));
Expand All @@ -112,7 +113,8 @@ const ReportPreview = (props) => {
onPressOut={() => ControlSelection.unblock()}
onLongPress={(event) => showContextMenuForReport(event, props.contextMenuAnchor, props.chatReportID, props.action, props.checkIfContextMenuActive)}
style={[styles.flexRow, styles.justifyContentBetween]}
focusable
accessibilityRole="button"
accessibilityLabel={props.translate('iou.viewDetails')}
>
<View style={[styles.flexShrink1]}>
{props.iouReport.hasOutstandingIOU ? (
Expand Down Expand Up @@ -140,7 +142,7 @@ const ReportPreview = (props) => {
src={Expensicons.ArrowRight}
fill={StyleUtils.getIconFillColor(getButtonState(props.isHovered))}
/>
</Pressable>
</PressableWithoutFeedback>
))}
{isCurrentUserManager && !ReportUtils.isSettled(props.iouReport.reportID) && (
<SettlementButton
Expand Down