Fix crash while changing contact method by hungvu193 · Pull Request #19941 · Expensify/App

hungvu193 · 2023-06-01T06:40:41Z

Details

Fix crash while changing contact method

Fixed Issues

$ #19611
PROPOSAL: #19611 (comment)

Tests

Login with any account, from LHN click on any report or thread.
Make sure that report or thread have the time above the composer.
Go to settings > Profile > Contact method
Change the current default contact method
Go to settings > Profile > Contact method
Change the current default contact method to the previous one
Verify that app is not crashed.

Verify that no errors appear in the JS console

Offline tests

Bug is related to offline mode itself. No extra steps needed.

QA Steps

Login with any account, from LHN click on any report or thread.
Make sure that report or thread have the time above the composer.
Go to settings > Profile > Contact method
Change the current default contact method
Go to settings > Profile > Contact method
Change the current default contact method to the previous one
Verify that app is not crashed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots

Web

contact.method.mov

Mobile Web - Chrome

Screen.Recording.2023-06-01.at.13.45.02.mov

Mobile Web - Safari

Screen.Recording.2023-06-01.at.13.43.00.mov

Desktop

desktop.mov

iOS

Screen.Recording.2023-06-01.at.13.41.21.mov

Android

Screen.Recording.2023-06-01.at.13.45.58.mov

melvin-bot · 2023-06-01T06:46:42Z

@NikkiWines @allroundexperts One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allroundexperts · 2023-06-01T09:37:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-01.at.4.36.27.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-06-01.at.4.48.49.PM.mov

Mobile Web - Safari

Screen.Recording.2023-06-01.at.4.48.16.PM.mov

Desktop

Screen.Recording.2023-06-01.at.4.43.12.PM.mov

iOS

Screen.Recording.2023-06-01.at.4.50.13.PM.mov

Android

Screen.Recording.2023-06-01.at.4.49.34.PM.mov

allroundexperts · 2023-06-01T10:54:50Z

@hungvu193 Can you use lodashGet in the ParticipantLocalTime component?

allroundexperts · 2023-06-01T10:56:10Z

Also, lets just keep on using personalDetails for the email and pass it as a parameter to the canShowReportRecipientLocalTime function.

hungvu193 · 2023-06-01T11:04:46Z

Also, lets just keep on using personalDetails for the email and pass it as a parameter to the canShowReportRecipientLocalTime function.

So you still want to use this.props.currentUserPersonalDetails.login for both reportParticipants and canShowReportRecipientLocalTime right?

allroundexperts · 2023-06-01T11:06:17Z

Also, lets just keep on using personalDetails for the email and pass it as a parameter to the canShowReportRecipientLocalTime function.

So you still want to use this.props.currentUserPersonalDetails.login for both reportParticipants and canShowReportRecipientLocalTime right?

Yes. Just pass this.props.currentUserPersonalDetails.login as a parameter to the canShowReportRecipientLocalTime function.

hungvu193 · 2023-06-01T11:14:38Z

Cool, I've just updated @allroundexperts

allroundexperts · 2023-06-01T11:25:57Z

        const reportRecipient = this.props.personalDetails[participantsWithoutExpensifyEmails[0]];
-        const shouldShowReportRecipientLocalTime = ReportUtils.canShowReportRecipientLocalTime(this.props.personalDetails, this.props.report) && !this.props.isComposerFullSize;
+        const shouldShowReportRecipientLocalTime =
+            ReportUtils.canShowReportRecipientLocalTime(this.props.personalDetails, this.props.report, this.props.currentUserPersonalDetails.login) && !this.props.isComposerFullSize;


@hungvu193 Please verify if canShowReportRecipientLocalTime function isn't used elsewhere. If so, then add this third parameter at other places as well!

Nice catch, I should notice this earlier.
Thank you @allroundexperts . I've just updated it again!

allroundexperts · 2023-06-01T11:35:57Z

@hungvu193 In the uploaded videos, I don't see the IOU thread being opened anywhere. If its not a requirement, then can you also update the test section of the PR?

hungvu193 · 2023-06-01T11:39:06Z

That's not the requirement I believe, lemme update the steps. 😀

hungvu193 · 2023-06-01T11:42:57Z

Updated!

allroundexperts · 2023-06-01T12:00:18Z

Updated!

@hungvu193 I think instead of IOU thread, the test steps need to include any thread. Since the error is specifically related to the ReportActionCompose component, we need to include in the test steps that a thread must be opened in the background.

hungvu193 · 2023-06-01T14:04:13Z

Tested and updated the steps as well @allroundexperts

allroundexperts

Looks good!

All yours @NikkiWines!

NikkiWines

Looks good, but @hungvu193 can you update your QA + testing steps to clarify what you mean by "Go to any thread or report that has participant time." please 🙇

hungvu193 · 2023-06-02T00:39:03Z

Thanks @NikkiWines . I updated it again!

OSBotify · 2023-06-02T01:27:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-02T12:40:31Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.3.23-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-06-02T13:20:02Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.3.23-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-06-05T19:05:32Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.23-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-06-05T19:30:08Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.23-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

parasharrajat · 2023-06-19T15:38:05Z


    render() {
-        const reportRecipientDisplayName = this.props.participant.firstName || this.props.participant.displayName;
+        const reportRecipientDisplayName = lodashGet(this.props, 'participant.firstName') || lodashGet(this.props, 'participant.displayName');


We should not be using the lodashGet here. participant prop is required here. So should never be rendering this component if participant is not present. In case, participant is undefined here, it mean the root cause is in upper tree not here.

cc: @NikkiWines

This is just a safe guard. We've fixed the root cause as well.

This safe guard promotes more bugs. No one should be able to use this component without passing the participation and error should be thrown to make it clear during development. This should be reverted.

hungvu193 marked this pull request as ready for review June 1, 2023 06:46

hungvu193 requested a review from a team as a code owner June 1, 2023 06:46

melvin-bot Bot requested review from NikkiWines and allroundexperts and removed request for a team June 1, 2023 06:46

hungvu193 mentioned this pull request Jun 1, 2023

[HOLD for payment 2023-06-12] [$1000] App crashes after changing default contact method #19611

Closed

6 tasks

use current login for the condition

1d8e214

hungvu193 force-pushed the fix-19611 branch from 0710cb1 to 1d8e214 Compare June 1, 2023 11:13

allroundexperts reviewed Jun 1, 2023

View reviewed changes

update shouldShowReportRecipientLocalTime params for other places

b8a231e

allroundexperts reviewed Jun 1, 2023

View reviewed changes

Comment thread src/pages/home/report/ReportActionsList.js

allroundexperts approved these changes Jun 1, 2023

View reviewed changes

NikkiWines approved these changes Jun 1, 2023

View reviewed changes

NikkiWines merged commit 0350c96 into Expensify:main Jun 2, 2023

OSBotify mentioned this pull request Jun 2, 2023

Deploy Checklist: New Expensify 2023-06-02 #20042

Closed

32 tasks

parasharrajat reviewed Jun 19, 2023

View reviewed changes

Uh oh!

Conversation

hungvu193 commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Uh oh!

melvin-bot Bot commented Jun 1, 2023

Uh oh!

allroundexperts commented Jun 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Jun 1, 2023

Uh oh!

allroundexperts commented Jun 1, 2023

Uh oh!

hungvu193 commented Jun 1, 2023

Uh oh!

allroundexperts commented Jun 1, 2023

Uh oh!

hungvu193 commented Jun 1, 2023

Uh oh!

allroundexperts Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

hungvu193 Jun 1, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts commented Jun 1, 2023

Uh oh!

hungvu193 commented Jun 1, 2023

Uh oh!

hungvu193 commented Jun 1, 2023

Uh oh!

allroundexperts commented Jun 1, 2023

Uh oh!

Uh oh!

hungvu193 commented Jun 1, 2023

Uh oh!

allroundexperts left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Jun 2, 2023

Uh oh!

OSBotify commented Jun 2, 2023

Uh oh!

OSBotify commented Jun 2, 2023

Uh oh!

OSBotify commented Jun 2, 2023

Uh oh!

OSBotify commented Jun 5, 2023

Uh oh!

OSBotify commented Jun 5, 2023

Uh oh!

parasharrajat Jun 19, 2023

Choose a reason for hiding this comment

Uh oh!

allroundexperts Jun 19, 2023

Choose a reason for hiding this comment

Uh oh!

parasharrajat Jun 19, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

hungvu193 commented Jun 1, 2023 •

edited

Loading

allroundexperts commented Jun 1, 2023 •

edited

Loading