Fix/regression 18110 composer should have the same height in other platforms by dukenv0307 · Pull Request #19516 · Expensify/App

dukenv0307 · 2023-05-24T10:02:03Z

Details

Composer in Android should have the same height in other platforms

Fixed Issues

$ #18110
PROPOSAL: #18110 (comment)
$ #19358

Tests

Open any chat
Lose focus from compose box
Verify Composer in all platforms should have the same height and hover over compose box and observe that few area above and below 'Write something...'
Verify app should display edit pointer on the whole compose box and on double click, it shouldn't select placeholder text

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open any chat
Lose focus from compose box
Verify Composer in all platforms should have the same height and hover over compose box and observe that few area above and below 'Write something...'
Verify app should display edit pointer on the whole compose box and on double click, it shouldn't select placeholder text

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos 18110

Web

Web.mov

Mobile Web - Chrome

chrome.mp4

Mobile Web - Safari

safari.mp4

Desktop

Desktop.mov

iOS

ios.mov

Android

Android.mov

Screenshots/Videos 19358

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-05-25T03:46:34Z

@MariaHCD Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2023-05-25T04:03:23Z

@MariaHCD I added the link to the issue is "#18110", but right format is "https://github.com/Expensify/App/issues/", so please help to assign reviewer again. Sorry for this inconvenience.

mananjadhav · 2023-05-25T06:54:36Z


    render() {
+        let paddingValue = 5;
+        if (this.props.numberOfLines === 1) paddingValue = 9;


Can this be moved to styles? I think it doesn't make sense to have styling added as code in render. Better to get it from styles.

I just moved it to StyleUtils. @mananjadhav please check again

mananjadhav · 2023-05-25T06:56:34Z

@dukenv0307 Can you remove the word REGRESSION and just keep the linked issue?

dukenv0307 · 2023-05-25T07:10:10Z

@dukenv0307 Can you remove the word REGRESSION and just keep the linked issue?

I updated

Co-authored-by: Tim Golen <tgolen@gmail.com>

mananjadhav

thanks for the changes @dukenv0307. I'll finish the checklist today.

mananjadhav · 2023-05-29T21:28:29Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-cusor-pointer-composer-size.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

desktop-cusor-pointer-composer-size.mov

iOS

Android

mananjadhav · 2023-05-29T23:04:31Z

@dukenv0307 for all my Android emulators, the height shows up as 38.2, unlike 38 in your screenshot (and other platforms).

cc - @tgolen

dukenv0307 · 2023-05-30T10:38:11Z

I tested this bug on main and the height shows up is 38.2 and this bug is not related to bug 18110. Should we fix this bug in another PR or another issue?

mananjadhav · 2023-05-31T16:39:24Z

I think it's best to fix in another PR. Thanks for highlighting that. Can you take the latest pull for main and resolve conflicts?

dukenv0307 · 2023-05-31T16:50:37Z

@mananjadhav I just updated.

mananjadhav · 2023-06-01T15:54:20Z

@tgolen did you get a chance to look at the previous comments?

mananjadhav · 2023-06-06T05:27:16Z

Quick bump @tgolen

dukenv0307 · 2023-06-07T04:28:04Z

@mananjadhav I just saw that ReportActionItemMessageEdit also used style textInputComposeSpacing, so I think we also need to update this style by getContainerComposeStyle

App/src/pages/home/report/ReportActionItemMessageEdit.js

Line 311 in c3b3a53

dukenv0307 · 2023-06-15T03:01:47Z

@mananjadhav @tgolen Please help review this PR to complete it when you have time.

mananjadhav · 2023-06-15T03:14:28Z

Thanks for the bump @dukenv0307. Can you resolve the conflicts please?

@tgolen I've tested this, can you please take a look at the PR?

dukenv0307 · 2023-06-15T03:24:57Z

@mananjadhav I resolved the conflict and also updated style for wrap view of composer in ReportActionItemMessageEdit as mentioned in this comment #19516 (comment). Please help to check again.

dukenv0307 · 2023-06-28T05:22:42Z

@tgolen Friendly bump to help us to take a look at the PR.

dukenv0307 · 2023-07-12T09:50:56Z

@mananjadhav @tgolen Friendly bump.

dukenv0307 · 2023-07-20T10:42:46Z

@mananjadhav What we should do to move forward with this PR?

tgolen · 2023-07-24T15:00:32Z

Hi! I was out on sabbatical for 2 months. Next time, if I (or anyone from Expensify) doesn't respond in a couple of days, please start asking for help in Slack to see what is going on and move forward with urgency on issues, not just waiting for an update indefinitely.

OSBotify · 2023-07-24T15:05:20Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-25T01:43:27Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.45-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-26T15:52:58Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.45-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mollfpr · 2023-09-19T16:15:11Z

+        paddingTop: paddingValue,
+        paddingBottom: paddingValue,
+    };
+}


✋ Coming from #26222

The composer padding is changed inconsistently due to the number of lines changing between 3 or more, it's noticeable while the composer is full size.

dukenv0307 added 8 commits May 24, 2023 14:56

Fix regression

009ea52

fix check native system

62c1cb9

fix recalculate padding vertical and check platform

d68d65b

fix eslint

c6f2bb2

add function to get container style of compose

cf53026

format code

3aef299

fix name variable

70c2cd5

add comment

2b40097

dukenv0307 changed the title ~~Fix/regression 18110~~ Fix/regression 18110 composer should have the same height in other platforms May 25, 2023

resolve conflict

da56416

dukenv0307 marked this pull request as ready for review May 25, 2023 03:46

dukenv0307 requested a review from a team as a code owner May 25, 2023 03:46

melvin-bot Bot requested review from MariaHCD and removed request for a team May 25, 2023 03:46

mananjadhav reviewed May 25, 2023

View reviewed changes

fix move calculate padding to style utils

c00d26e

MariaHCD requested review from tgolen and removed request for MariaHCD May 25, 2023 08:10

tgolen requested changes May 25, 2023

View reviewed changes

Comment thread src/styles/getContainerComposeStyles/index.js Outdated

Update src/styles/getContainerComposeStyles/index.js

24ca23f

Co-authored-by: Tim Golen <tgolen@gmail.com>

tgolen previously approved these changes May 29, 2023

View reviewed changes

mananjadhav previously approved these changes May 29, 2023

View reviewed changes

merge main

42860a0

dukenv0307 dismissed stale reviews from mananjadhav and tgolen via 42860a0 May 31, 2023 16:49

dukenv0307 added 2 commits June 15, 2023 10:17

merge main

93566fe

fix lint

dded931

merge main

79df68d

tgolen approved these changes Jul 24, 2023

View reviewed changes

tgolen merged commit 2200b81 into Expensify:main Jul 24, 2023

OSBotify mentioned this pull request Jul 25, 2023

Deploy Checklist: New Expensify 2023-07-25 #23522

Closed

kbecciv mentioned this pull request Jul 25, 2023

[$1000] Android - Conversation - Unable to lose focus in the composer #23553

Closed

6 tasks

melvin-bot Bot mentioned this pull request Jul 26, 2023

[HOLD for payment 2023-08-02] [HOLD for payment 2023-06-01] [HOLD for payment 2023-05-29] composer height is bigger in Android #19358

Closed

6 tasks

mollfpr mentioned this pull request Aug 31, 2023

[PAID] [$1000] Chat - Content shifts up and down for a few pixels while adding new line in expanded composer #26222

Closed

6 tasks

mollfpr reviewed Sep 19, 2023

View reviewed changes

Uh oh!

Conversation

dukenv0307 commented May 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos 18110

Screenshots/Videos 19358

Uh oh!

melvin-bot Bot commented May 25, 2023

Uh oh!

dukenv0307 commented May 25, 2023

Uh oh!

mananjadhav May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dukenv0307 May 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented May 25, 2023

Uh oh!

dukenv0307 commented May 25, 2023

Uh oh!

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented May 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented May 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented May 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented May 31, 2023

Uh oh!

dukenv0307 commented May 31, 2023

Uh oh!

mananjadhav commented Jun 1, 2023

Uh oh!

mananjadhav commented Jun 6, 2023

Uh oh!

dukenv0307 commented Jun 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dukenv0307 commented Jun 15, 2023

Uh oh!

mananjadhav commented Jun 15, 2023

Uh oh!

dukenv0307 commented Jun 15, 2023

Uh oh!

dukenv0307 commented Jun 28, 2023

Uh oh!

dukenv0307 commented Jul 12, 2023

Uh oh!

dukenv0307 commented Jul 20, 2023

Uh oh!

tgolen commented Jul 24, 2023

Uh oh!

OSBotify commented Jul 24, 2023

Uh oh!

OSBotify commented Jul 25, 2023

Uh oh!

OSBotify commented Jul 26, 2023

Uh oh!

mollfpr Sep 19, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

dukenv0307 commented May 24, 2023 •

edited

Loading

mananjadhav May 25, 2023 •

edited

Loading

dukenv0307 May 25, 2023 •

edited

Loading

mananjadhav commented May 29, 2023 •

edited

Loading

mananjadhav commented May 29, 2023 •

edited

Loading

dukenv0307 commented May 30, 2023 •

edited

Loading

dukenv0307 commented Jun 7, 2023 •

edited

Loading