Skip to content

Fix 19226 holding remove button only delete one number #19432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 1 commit into from
May 23, 2023
Merged

Fix 19226 holding remove button only delete one number #19432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/pages/iou/steps/MoneyRequestAmountPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ class MoneyRequestAmountPage extends React.Component {
* @param {String} key
*/
updateAmountNumberPad(key) {
if (!this.textInput.isFocused()) {
if (this.state.shouldUpdateSelection && !this.textInput.isFocused()) {

@abdulrahuman5196 abdulrahuman5196 May 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice that you have incorporated the suggestion as well #19226 (comment) 👍

this.textInput.focus();
}

Expand Down Expand Up @@ -261,6 +261,9 @@ class MoneyRequestAmountPage extends React.Component {
*/
updateLongPressHandlerState(value) {
this.setState({shouldUpdateSelection: !value});
if (!value && !this.textInput.isFocused()) {
this.textInput.focus();
}
}

/**
Expand Down