-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Refactor ReportActionItem to use hooks
#18809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
2e6b8e6
add back ReportActionItem
jasperhuangg c6304ee
add back ReportActionItemMessageEdit and refPropTypes
jasperhuangg 29ac1a9
add back pressableWithSecondaryInteraction
jasperhuangg 2f92de6
fix merge conflicts
jasperhuangg 845a86b
merge main
jasperhuangg 1eaf072
fix console warnings
jasperhuangg c49dff8
wip
jasperhuangg d633aad
merge main
jasperhuangg 5b862a3
fix long press to pull up context menu
jasperhuangg 666995b
remove unused
jasperhuangg dc04b9f
Merge branch 'main' into jasper-refactorReportActionItemHooks1
jasperhuangg 0b01e76
remove weird stuff from merge
jasperhuangg b925ee1
Update src/pages/home/report/ReportActionItem.js
jasperhuangg a61a258
Update src/pages/home/report/ReportActionItem.js
jasperhuangg 1abb820
add hasOutstandingIOU into proptypes
jasperhuangg a16830f
Merge branch 'jasper-refactorReportActionItemHooks1' of github.com:Ex…
jasperhuangg 891495a
fix typo
jasperhuangg 41b5cd6
Update src/pages/home/report/ReportActionItem.js
jasperhuangg 1430ac0
default prop types
jasperhuangg 19d3495
conflicts
jasperhuangg 3c6dc29
Merge branch 'main' of github.com:Expensify/App into jasper-refactorR…
jasperhuangg 25a09b7
fix right click
jasperhuangg 575c306
remove unused line break
jasperhuangg 5617258
typo
jasperhuangg cccebb8
Update src/components/PressableWithSecondaryInteraction/index.js
jasperhuangg 49dff2b
Update src/components/PressableWithSecondaryInteraction/index.js
jasperhuangg c5b6350
Fix proptypes errors
jasperhuangg a73f05e
Merge branch 'jasper-refactorReportActionItemHooks1' of github.com:Ex…
jasperhuangg d7bcce7
Merge branch 'main' of github.com:Expensify/App into jasper-refactorR…
jasperhuangg 99dd319
resolve merge conflicts
jasperhuangg 7f326f1
fix error passing ref into tooltips
jasperhuangg 7620f3a
remove unused
jasperhuangg 852f7bc
consolidate logic
jasperhuangg 8a9b271
fix condition
jasperhuangg d95494a
consolidate logic
jasperhuangg 155ead3
resolve conflicts
jasperhuangg 4a35a5a
prettier
jasperhuangg 3a6dfe5
Merge branch 'main' of github.com:Expensify/App into jasper-refactorR…
jasperhuangg de7f990
use _.contains to simplify condition
jasperhuangg c52ac84
apply changes from #18523
jasperhuangg 8a5cb7e
Update src/styles/getTooltipStyles.js
jasperhuangg 78fecb9
use lodashGet
jasperhuangg e3367d2
fix merge conflict
jasperhuangg eb17e6a
change back to conditional logic
jasperhuangg 11a9021
check tooltip.current first, in case tooltip.contains doesn't exist
jasperhuangg 54c7a12
simplify logic with variable
jasperhuangg a98c97d
Update src/styles/getTooltipStyles.js
jasperhuangg 992a4b6
Update src/styles/getTooltipStyles.js
jasperhuangg 42c8ea7
merge main
jasperhuangg 77c9d55
Merge branch 'jasper-refactorReportActionItemHooks1' of github.com:Ex…
jasperhuangg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import PropTypes from 'prop-types'; | ||
|
|
||
| export default PropTypes.oneOfType([PropTypes.func, PropTypes.object]); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.