show individual split amount on Bill Split IOU Previews by 0xmiroslav · Pull Request #18715 · Expensify/App

0xmiroslav · 2023-05-10T13:01:25Z

Details

show individual split amount on Bill Split IOU Previews

Fixed Issues

$ #18706
PROPOSAL: Coming from https://expensify.slack.com/archives/C02NK2DQWUX/p1683711639585659

Tests

Login any account
Create a bill split with 3+ users in any group chat
Look at the IOUPreview
Verify that the Split AMOUNT shows beneath the participant avatars

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-05-10T13:01:57Z

@Santhosh-Sellavel @PauloGasparSv One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

0xmiroslav · 2023-05-10T13:02:25Z

@Julesssss @mountiny ready for review 🚀

mountiny · 2023-05-10T13:19:47Z

Running into this issue

but not sure if its related, seems like the chat reportID is not right

The job 1 seems to be failing too

0xmiroslav · 2023-05-10T13:22:26Z

but not sure if its related, seems like the chat reportID is not right

I believe this will happen on main too

Not sure why job1 fails. Can you please re-run?

mountiny · 2023-05-10T13:25:17Z

From logs it seems like the chat report id of the splits is not correct, would begreat if @Julesssss could try too to see

mountiny

Getting error but it does not look like its related to these changes. The UI looks good fwiw

Julesssss

Changes looking good. As for the error, I saw this briefly myself yesterday after merging main, but I don't think it's related to these changes.

Julesssss · 2023-05-10T16:08:57Z

Here's a separate issue for the error

Julesssss · 2023-05-10T16:09:51Z

All yours @Santhosh-Sellavel. Signing out/in should resolve the issue seen above 🤞

…ssue-18706-split-amount-iou-preview

Santhosh-Sellavel · 2023-05-11T14:15:40Z

@0xmiroslav Seems we ran into conflicts again.

…706-split-amount-iou-preview

0xmiroslav · 2023-05-11T14:31:14Z

@0xmiroslav Seems we ran into conflicts again.

Fixed!

Santhosh-Sellavel · 2023-05-11T15:09:42Z

Cool, thanks will review shortly

Santhosh-Sellavel · 2023-05-11T15:31:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Santhosh-Sellavel · 2023-05-11T17:39:50Z

Should we show splits only for the last request? @mountiny or @Julesssss

Santhosh-Sellavel · 2023-05-11T17:42:18Z

Signing out/in should resolve the issue seen above 🤞

As far as I see, I have no problem creating the split in new group chats, but it happens for old group chats.

Julesssss · 2023-05-12T07:45:41Z

As far as I see, I have no problem creating the split in new group chats, but it happens for old group chats.

Ah. then this is a separate bug I think

Santhosh-Sellavel · 2023-05-12T17:54:46Z

Sorry @0xmiroslav We have conflicts again, please resolve them thanks.

…ssue-18706-split-amount-iou-preview

0xmiroslav · 2023-05-12T19:28:24Z

+            onPressHandler(event);
+        },
+        [onPressHandler],
+    );


this file change is just to fix prettier diff so you can ignore

0xmiroslav · 2023-05-12T19:28:48Z

Sorry @0xmiroslav We have conflicts again, please resolve them thanks.

Done!

Santhosh-Sellavel

As this is more towards UI which looks good, tests well approving!

cc: @mountiny @Julesssss

mountiny

Thank you both @0xmiroslav @Santhosh-Sellavel

github-actions · 2023-05-14T10:19:08Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

0xmiroslav · 2023-05-14T10:29:36Z

@mountiny we can merge this. @Julesssss already approved before merge conflict

mountiny · 2023-05-14T10:34:52Z

@0xmiroslav just to confrim I am not sure if all the code necessary in Staging? Dont want to get merge conflicts wiht the CP

0xmiroslav · 2023-05-14T10:38:43Z

@0xmiroslav just to confrim I am not sure if all the code necessary in Staging? Dont want to get merge conflicts wiht the CP

I think it's fine to remove CP Staging as this is not extreme urgent PR

mountiny · 2023-05-14T10:51:04Z

Cool agreed, thanks!

OSBotify · 2023-05-14T10:56:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-15T09:19:17Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.3.14-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-05-17T00:19:07Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.14-14 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

show individual split amount on Bill Split IOU Previews

8286a9b

0xmiroslav requested a review from a team as a code owner May 10, 2023 13:01

melvin-bot Bot requested review from PauloGasparSv and Santhosh-Sellavel and removed request for a team May 10, 2023 13:01

PauloGasparSv requested review from Julesssss and removed request for PauloGasparSv May 10, 2023 13:13

PauloGasparSv assigned 0xmiroslav May 10, 2023

mountiny reviewed May 10, 2023

View reviewed changes

Julesssss previously approved these changes May 10, 2023

View reviewed changes

amyevans mentioned this pull request May 10, 2023

Changes to IOUAction and IOUPreview #18698

Merged

57 tasks

Merge branch 'main' of https://github.com/0xmiroslav/Expensify into i…

64fe52d

…ssue-18706-split-amount-iou-preview

0xmiroslav dismissed Julesssss’s stale review via 64fe52d May 11, 2023 03:52

Merge branch 'main' of https://github.com/Expensify/App into issue-18…

dadb281

…706-split-amount-iou-preview

Julesssss previously approved these changes May 11, 2023

View reviewed changes

Merge branch 'main' of https://github.com/0xmiroslav/Expensify into i…

f9b9377

…ssue-18706-split-amount-iou-preview

0xmiroslav dismissed Julesssss’s stale review via f9b9377 May 12, 2023 19:26

0xmiroslav commented May 12, 2023

View reviewed changes

Santhosh-Sellavel approved these changes May 12, 2023

View reviewed changes

mountiny approved these changes May 14, 2023

View reviewed changes

mountiny added the CP Staging label May 14, 2023

mountiny removed the CP Staging label May 14, 2023

mountiny merged commit 148517a into Expensify:main May 14, 2023

OSBotify mentioned this pull request May 15, 2023

Deploy Checklist: New Expensify 2023-05-15 #18938

Closed

67 tasks

melvin-bot Bot mentioned this pull request May 16, 2023

[HOLD for payment 2023-05-23] Show individual split amount on Bill Split IOU Previews #18706

Closed

6 tasks

Uh oh!

Conversation

0xmiroslav commented May 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 10, 2023

Uh oh!

0xmiroslav commented May 10, 2023

Uh oh!

mountiny commented May 10, 2023

Uh oh!

0xmiroslav commented May 10, 2023

Uh oh!

mountiny commented May 10, 2023

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss left a comment

Choose a reason for hiding this comment

Uh oh!

Julesssss commented May 10, 2023

Uh oh!

Julesssss commented May 10, 2023

Uh oh!

Santhosh-Sellavel commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xmiroslav commented May 11, 2023

Uh oh!

Santhosh-Sellavel commented May 11, 2023

Uh oh!

Santhosh-Sellavel commented May 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel commented May 11, 2023

Uh oh!

Santhosh-Sellavel commented May 11, 2023

Uh oh!

Julesssss commented May 12, 2023

Uh oh!

Santhosh-Sellavel commented May 12, 2023

Uh oh!

0xmiroslav May 12, 2023

Choose a reason for hiding this comment

Uh oh!

0xmiroslav commented May 12, 2023

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 14, 2023

Uh oh!

0xmiroslav commented May 14, 2023

Uh oh!

mountiny commented May 14, 2023

Uh oh!

0xmiroslav commented May 14, 2023

Uh oh!

mountiny commented May 14, 2023

Uh oh!

OSBotify commented May 14, 2023

Uh oh!

OSBotify commented May 15, 2023

Uh oh!

OSBotify commented May 17, 2023

Uh oh!

Reviewers

0xmiroslav commented May 10, 2023 •

edited

Loading

Santhosh-Sellavel commented May 11, 2023 •

edited

Loading

Santhosh-Sellavel commented May 11, 2023 •

edited

Loading