-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: web does not show not show notifications for not active window #18065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,6 +8,13 @@ import {AppState} from 'react-native'; | |
| */ | ||
| const isVisible = () => AppState.currentState === 'active'; | ||
|
|
||
| /** | ||
| * @returns {Boolean} | ||
| */ | ||
| function hasFocus() { | ||
| return true; | ||
| } | ||
|
Comment on lines
+14
to
+16
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Assuming it has focus is weird?
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bump @tienifr cc: @luacmartins thoughts?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it's fine since checking isVisible should be enough on the native case.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I see your point @Santhosh-Sellavel. In the future, we might want this function to behave as |
||
|
|
||
| /** | ||
| * Adds event listener for changes in visibility state | ||
| * | ||
|
|
@@ -24,5 +31,6 @@ function onVisibilityChange(callback) { | |
|
|
||
| export default { | ||
| isVisible, | ||
| hasFocus, | ||
| onVisibilityChange, | ||
| }; | ||
Uh oh!
There was an error while loading. Please reload this page.