fix newlines are removed when copying chat message by bernhardoj · Pull Request #16733 · Expensify/App

bernhardoj · 2023-03-30T06:45:01Z

Details

Some newlines are removed when we copy a chat message to a text editor.

Fixed Issues

$ #16473
PROPOSAL: #16473 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Open any message
Send a message with multiple blank lines, for example

Line1




Line2

Copy the message you just sent
a. Web/Desktop (test for both case):
i. select the text and press ctrl/cmd+c
ii. right click the message and click "Copy to clipboard"
b. Android/iOS/mWeb: Long press the message and press "Copy to clipboard"
Paste the text to any text editor
Verify the number of lines is the same (does not change)

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-03-31.at.01.08.50.1.mov

Mobile Web - Chrome

WhatsApp.Video.2023-03-29.at.23.57.42.mp4

Mobile Web - Safari

Screen.Recording.2023-03-31.at.01.16.13.mov

Desktop

Screen.Recording.2023-03-31.at.01.06.34.1.mov

iOS

Screen.Recording.2023-03-31.at.01.21.58.mov

Android

WhatsApp.Video.2023-03-30.at.01.20.55.mp4

MelvinBot · 2023-03-30T06:45:09Z

@NikkiWines @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-03-30T06:45:40Z

Sorry, it takes long. I have a problem with my device and it's totally unusable right now. I will complete the video after the problem is resolved.

bernhardoj · 2023-03-30T17:36:43Z

Completed the video and checklist.

eVoloshchak · 2023-03-31T10:15:51Z

Reviewing in a couple of hours

eVoloshchak · 2023-03-31T14:48:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-03-31.at.17.53.17.mov

Mobile Web - Chrome

Screen_Recording_20230331-180203_Chrome.mp4

Mobile Web - Safari

Screen.Recording.2023-03-31.at.17.58.18.mov

Desktop

Screen.Recording.2023-03-31.at.17.56.23.mov

iOS

Screen.Recording.2023-03-31.at.17.59.15.mov

Android

Screen_Recording_20230331-180112_New.Expensify.mp4

eVoloshchak · 2023-03-31T15:03:39Z

    domRepresentation.children = _.map(domRepresentation.children, replaceNodes);

-    const newHtml = render(domRepresentation);
+    // Newline characters need to be removed here because the HTML could contains both newlines and <br> tags, and when


Suggested change

// Newline characters need to be removed here because the HTML could contains both newlines and <br> tags, and when

// Newline characters need to be removed here because the HTML could contain both newlines and <br> tags, and when

eVoloshchak · 2023-03-31T15:04:12Z

There is a small typo above, other that that looks good and test well

bernhardoj · 2023-03-31T15:32:17Z

Fixed!

eVoloshchak

LGTM
cc: @NikkiWines

NikkiWines

Looks good and tests well!!

OSBotify · 2023-03-31T17:20:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-03T19:27:57Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 1.2.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-04-05T02:28:44Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.94-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix newlines are removed when copying chat message

2e2ccf5

bernhardoj requested a review from a team as a code owner March 30, 2023 06:45

melvin-bot Bot requested review from NikkiWines and eVoloshchak and removed request for a team March 30, 2023 06:45

eVoloshchak suggested changes Mar 31, 2023

View reviewed changes

fix typo

d541220

eVoloshchak approved these changes Mar 31, 2023

View reviewed changes

NikkiWines assigned bernhardoj Mar 31, 2023

NikkiWines approved these changes Mar 31, 2023

View reviewed changes

NikkiWines merged commit ef54707 into Expensify:main Mar 31, 2023

OSBotify mentioned this pull request Apr 3, 2023

Deploy Checklist: New Expensify 2023-04-03 #16880

Closed

21 tasks

MelvinBot mentioned this pull request Apr 5, 2023

[HOLD for payment 2023-04-12] [$1000] Some new lines are removed from multiline message #16473

Closed

6 tasks

	// Newline characters need to be removed here because the HTML could contains both newlines and <br> tags, and when
	// Newline characters need to be removed here because the HTML could contain both newlines and <br> tags, and when

Conversation

bernhardoj commented Mar 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Mar 30, 2023

Uh oh!

bernhardoj commented Mar 30, 2023

Uh oh!

bernhardoj commented Mar 30, 2023

Uh oh!

eVoloshchak commented Mar 31, 2023

Uh oh!

eVoloshchak commented Mar 31, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eVoloshchak Mar 31, 2023

Choose a reason for hiding this comment

Uh oh!

eVoloshchak commented Mar 31, 2023

Uh oh!

bernhardoj commented Mar 31, 2023

Uh oh!

eVoloshchak left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 31, 2023

Uh oh!

OSBotify commented Apr 3, 2023

Uh oh!

OSBotify commented Apr 5, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bernhardoj commented Mar 30, 2023 •

edited

Loading

eVoloshchak commented Mar 31, 2023 •

edited

Loading