Always show the last closed report action - #15474
Conversation
|
@parasharrajat @neil-marcellini One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Doing my dinner and taking it next afterwards. |
|
👀 |
|
Haven't forgotten this one. |
For this, do you mean to merge the first account into the second? No getting what is old or new here?
Do I need a domain-based email account or Gmail one will work for it? |
|
Yeah I have the same questions. I think we need to merge the second account into the third so that the old
|
|
Hmm now when I go to merge accounts I get an error. I'll look into that. |
|
Oh I see, the accounts can't be on the wallet beta as shown in the backend here. I'll comment out that line to proceed. |
There was a problem hiding this comment.
The code tests well using the test steps I posted in a previous comment, and the changes look good to me. After you fix that lint error I think it's good to go. Also please update the testing steps to be more clear.
I'm seeing the correct archive reason.
| * @returns {Array} | ||
| */ | ||
| function getSortedReportActionsForDisplay(reportActions) { | ||
| function filterOutDeprecatedReportActions(reportActions) { |
There was a problem hiding this comment.
👍 nice I like that you refactored this into a separate function and gave it a descriptive name.
|
Sorry for the it not being more clear, i havent counted the admin account as first or second, so first was the first non-admin member. Will updat |
Do I need a domain-based email account or Gmail one will work for it? |
|
@parasharrajat Sorry, I am also not fully aware if anything special is required to test this. I hoped not, given @neil-marcellini has tested this and it worked well I think we can proceed with merging once I fix the lint issue. Thank you both! |
|
@neil-marcellini @parasharrajat Ready to fill out the reviewer checklist and merge, thanks! |
|
It looks good to me as well. I will complete the. Checklist in about 2 hours from now. |
The account needs to be on the |
|
@parasharrajat How is this one looking? Would be great to get this merged soon before we deploy today. Thanks! |
|
Yes, checking this only now. |
|
I checked it and it seems that I need the beta access from backend, otherwise, workspace chat won't show in member accounts.
I don't know if my account is on that list. I won't be able to test it without that information. @mountiny @neil-marcellini. |
|
@parasharrajat I think we can skip this testing on all platforms, Neil has confirmed this works fine locally and we will test this thoroughly in Staging with Tom so we will catch any issue there nonetheless. Can you just fill in the checklist and note Neil tested web and we will test the entire flow in staging? |
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
Done @mountiny |
|
Thanks @parasharrajat |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
This is merely updating the ReportFooter logic on how to get the closer report action and does not touch Search page logic. I think we are fine here and it was a one off, removing the Deploy blocker label. Let me know if you think otherwise. |
|
This is building right now but should be ready to test in an hour and tomorrow @trjExpensify |
|
🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.78-0 🚀
|
|
Okay, going to jump into this PR review now. |
|
Is this related? Created a workspace and my own policyExpenseChat shows with this OpenReport auth error: tom+wcrun10@trj.chat |
|
tom+emp17@trj.chat
|
|
So the common denominator is that we're running into this bug when trying to access your own workspace chat. For example, this is the admin looking at emp17's report just fine:
|
|
It's traced back to this PR I think: https://github.com/Expensify/Auth/pull/7576 |
|
Okay, that's as much as I can do here to test this PR given that blocker. |
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.2.78-0 🚀
|
Details
Usually there is only one
closedreport action in a report, however, in case of merging two accounts, when the old account has some archive policy expense chats, there is another closed report action added to the report. The old once (in this scenario -user removed from policy) stays in the report so we need to make sure the reportAction we show in the report footer is theclosedreport action with the latestcreatedfield.In this PR have added a new method which will filter the report actions for only those which are closed, sorts them and shows the latest one meaning we will always display the most up-to-date archive reason.
Fixed Issues
$ #14292
Tests
accout
Offline tests
N/A
QA Steps
Same as test. Will be queued internally by @trjExpensify
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android