Skip to content

Fix URL's not displaying on hover on enable payments page #14478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MonilBhavsar merged 1 commit into from
Jan 26, 2023
Merged

Fix URL's not displaying on hover on enable payments page #14478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/pages/EnablePayments/TermsPage/LongTermsForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import * as Localize from '../../../libs/Localize';
import CONST from '../../../CONST';
import Icon from '../../../components/Icon';
import * as Expensicons from '../../../components/Icon/Expensicons';
import * as Link from '../../../libs/actions/Link';
import TextLink from '../../../components/TextLink';

const termsData = [
{
Expand Down Expand Up @@ -132,12 +132,12 @@ const LongTermsForm = () => (

<View style={styles.flexRow}>
<Icon style={styles.flex1} src={Expensicons.Printer} />
<Text
style={[styles.link, styles.ml1]}
onPress={() => Link.openExternalLink(CONST.FEES_URL)}
<TextLink
style={styles.ml1}
href={CONST.FEES_URL}
>
{Localize.translateLocal('termsStep.longTermsForm.printerFriendlyView')}
</Text>
</TextLink>
</View>
</>
);
Expand Down
16 changes: 5 additions & 11 deletions src/pages/EnablePayments/TermsPage/ShortTermsForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import styles from '../../../styles/styles';
import Text from '../../../components/Text';
import * as Localize from '../../../libs/Localize';
import CONST from '../../../CONST';
import * as Link from '../../../libs/actions/Link';
import TextLink from '../../../components/TextLink';

const ShortTermsForm = () => (
<>
Expand Down Expand Up @@ -152,23 +152,17 @@ const ShortTermsForm = () => (
<Text style={styles.mb3}>
{Localize.translateLocal('termsStep.shortTermsForm.generalInfo')}
{' '}
<Text
style={styles.link}
onPress={() => Link.openExternalLink(CONST.CFPB_PREPAID_URL)}
>
<TextLink href={CONST.CFPB_PREPAID_URL}>
{CONST.TERMS.CFPB_PREPAID}
</Text>
</TextLink>
.
</Text>
<Text>
{Localize.translateLocal('termsStep.shortTermsForm.conditionsDetails')}
{' '}
<Text
style={styles.link}
onPress={() => Link.openExternalLink(CONST.FEES_URL)}
>
<TextLink href={CONST.FEES_URL}>
{CONST.TERMS.USE_EXPENSIFY_FEES}
</Text>
</TextLink>
Comment on lines -166 to +165

@QichenZhu QichenZhu Mar 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change made an external link internal and caused #84603. We fixed it in #84732.

{' '}
{Localize.translateLocal('termsStep.shortTermsForm.conditionsPhone')}
</Text>
Expand Down
Loading