Skip to content

Convert hardware bitmap to software bitmap for Android notification avatar cropping #13391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arosiclair merged 2 commits into from
Dec 27, 2022
Merged

Convert hardware bitmap to software bitmap for Android notification avatar cropping #13391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dc5ab5
Convert notification avatar to software bitmap for Android
StefanNemeth Dec 7, 2022
15dccee
Merge branch 'Expensify:main' into bug/android_notifications_avatar
StefanNemeth Dec 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...pp/src/main/java/com/expensify/chat/customairshipextender/CustomNotificationProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,9 @@ private void createAndRegisterNotificationChannel(@NonNull Context context) {
* @param bitmap The bitmap image to modify.
*/
public Bitmap getCroppedBitmap(Bitmap bitmap) {
// Convert hardware bitmap to software bitmap so it can be drawn on the canvas
bitmap = bitmap.copy(Config.ARGB_8888, true);

Bitmap output = Bitmap.createBitmap(bitmap.getWidth(),
bitmap.getHeight(), Config.ARGB_8888);
Canvas canvas = new Canvas(output);
Expand Down