Skip to content

Do not make changes to IOU locally if currencies differ #12960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 2 commits into from
Nov 25, 2022
+1 −10
Merged

Do not make changes to IOU locally if currencies differ #12960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6986408
Do not make changes to IOU locally if currencies differ
youssef-lr Nov 23, 2022
96ed054
Fix linting
youssef-lr Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions src/libs/IOUUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
import Onyx from 'react-native-onyx';
import lodashGet from 'lodash/get';
import ONYXKEYS from '../ONYXKEYS';
import CONST from '../CONST';

let isNetworkOffline = false;
Onyx.connect({
key: ONYXKEYS.NETWORK,
callback: val => isNetworkOffline = lodashGet(val, 'isOffline', false),
});

/**
* Calculates the amount per user given a list of participants
* @param {Array} participants - List of logins for the participants in the chat. It should not include the current user's login.
Expand Down Expand Up @@ -50,7 +41,7 @@ function calculateAmount(participants, total, isDefaultUser = false) {
* @returns {Object}
*/
function updateIOUOwnerAndTotal(iouReport, actorEmail, amount, currency, type = CONST.IOU.REPORT_ACTION_TYPE.CREATE) {
if (currency !== iouReport.currency && isNetworkOffline) {
if (currency !== iouReport.currency) {
return iouReport;
}

Expand Down