Skip to content

Fix email keyboard type #12827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 3 commits into from
Nov 22, 2022
Merged

Fix email keyboard type #12827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f7c7a2
fix email keyboard type
gadhiyamanan Nov 15, 2022
57de41d
remove getEmailKeyboardType
gadhiyamanan Nov 15, 2022
99a2f58
Merge branch 'main' into fixEmailKeyboardType
gadhiyamanan Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/libs/getEmailKeyboardType/index.js
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions src/libs/getEmailKeyboardType/index.native.js
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions src/pages/signin/LoginForm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import withWindowDimensions, {windowDimensionsPropTypes} from '../../components/
import compose from '../../libs/compose';
import canFocusInputOnScreenFocus from '../../libs/canFocusInputOnScreenFocus';
import withLocalize, {withLocalizePropTypes} from '../../components/withLocalize';
import getEmailKeyboardType from '../../libs/getEmailKeyboardType';
import TextInput from '../../components/TextInput';
import * as ValidationUtils from '../../libs/ValidationUtils';
import * as LoginUtils from '../../libs/LoginUtils';
Expand All @@ -24,6 +23,7 @@ import networkPropTypes from '../../components/networkPropTypes';
import * as ErrorUtils from '../../libs/ErrorUtils';
import DotIndicatorMessage from '../../components/DotIndicatorMessage';
import * as CloseAccount from '../../libs/actions/CloseAccount';
import CONST from '../../CONST';

const propTypes = {
/** Should we dismiss the keyboard when transitioning away from the page? */
Expand Down Expand Up @@ -177,7 +177,7 @@ class LoginForm extends React.Component {
onSubmitEditing={this.validateAndSubmitForm}
autoCapitalize="none"
autoCorrect={false}
keyboardType={getEmailKeyboardType()}
keyboardType={CONST.KEYBOARD_TYPE.EMAIL_ADDRESS}
/>
</View>
{!_.isEmpty(this.props.account.success) && (
Expand Down