fix scroll speed of InvertedFlatList by dbond09 · Pull Request #12602 · Expensify/App

dbond09 · 2022-11-09T16:34:35Z

Details

The scroll speed on the chat view was inconsistent with the speed observed in other applications and websites, being much faster. This PR fixes the issue, making the scroll speed feel as expected.

Fixed Issues

$ #10654
PROPOSAL: #10654 (comment)

Tests

Open a chat with many messages
Verify the scroll speed is similar to other apps and browser pages so that it does not feel out of place

Verify that no errors appear in the JS console

QA Steps

Open a chat with many messages
Verify the scroll speed is similar to other apps and browser pages so that it does not feel out of place

Verify that no errors appear in the JS console

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Screen.Recording.2022-11-09.at.16.58.08.mov

Mobile Web - Chrome

chrome.webm

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.13.-.2022-11-09.at.17.07.22.mp4

Desktop

Screen.Recording.2022-11-09.at.17.19.40.mov

iOS

Simulator.Screen.Recording.-.iPhone.13.-.2022-11-09.at.17.06.05.mp4

Android

android.webm

github-actions · 2022-11-09T16:34:52Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

mountiny

@dbond09 Thank you! Can you please sign the CLA check?

dbond09 · 2022-11-09T17:17:36Z

I have read the CLA Document and I hereby sign the CLA

Santhosh-Sellavel · 2022-11-13T12:41:45Z

                ref={el => this.list = el}
                shouldMeasureItems
                contentContainerStyle={StyleSheet.compose(this.props.contentContainerStyle, styles.justifyContentEnd)}
-                style={{transform: [{translateX: 0}, {translateY: 0}, {scaleY: -1}]}}


@dbond09 Can you show some clarity on why we don't need this also?

When the inverted attribute is set on a FlatList, it is also passed to the underlying VirtualizedList, which already defines the scaleY transform that we need here.

https://github.com/necolas/react-native-web/blob/fa47f80d34ee6cde2536b2a2241e326f84b633c4/packages/react-native-web/src/vendor/react-native/VirtualizedList/index.js#L2158-L2160

Cool thanks!

mountiny

Tested on web and seems alright to me, time and other situations will show if the speed is exactly as we want. Great job!

@dbond09 can you please add some content to the Details section of the PR body and also update the test/QA steps to mention: the scroll speed is similar to other apps and browser pages so that it does not feel out of place

Thank you!

Santhosh-Sellavel · 2022-11-14T18:31:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Web_scroll.mov

Desktop

Screen.Recording.2022-11-14.at.11.36.04.PM.mov

Android & iOS Native

Native_Scroll.mov

Android & iOS mWeb

Uploading mWeb_Scroll.mov…

Santhosh-Sellavel

Checklist & Recordings : #12602 (comment)

LGTM tests well!
All you @mountiny

mountiny

Amazing, thank you guys so much!

@dbond09 Congratulations to your first PR!!! 🎉 onwards to many more 🍾

melvin-bot · 2022-11-14T22:16:35Z

@mountiny looks like this was merged without the checklist test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2022-11-14T22:16:56Z

Not an emergency, test were passing.

OSBotify · 2022-11-14T22:21:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

roryabraham · 2022-11-15T00:48:44Z

Stoked for this PR

mountiny · 2022-11-15T09:37:15Z

Same same, my brain melts a little everytime the scroll is weird.

OSBotify · 2022-11-15T21:58:23Z

🚀 Deployed to staging by @mountiny in version: 1.2.28-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-11-15T23:40:24Z

🚀 Deployed to staging by @mountiny in version: 1.2.28-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-11-17T07:37:25Z

🚀 Deployed to production by @roryabraham in version: 1.2.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix scroll speed of InvertedFlatList

46c39ba

dbond09 requested a review from a team as a code owner November 9, 2022 16:34

melvin-bot Bot requested review from Santhosh-Sellavel and mountiny and removed request for a team November 9, 2022 16:34

mountiny reviewed Nov 9, 2022

View reviewed changes

Santhosh-Sellavel reviewed Nov 13, 2022

View reviewed changes

mountiny reviewed Nov 14, 2022

View reviewed changes

Santhosh-Sellavel approved these changes Nov 14, 2022

View reviewed changes

mountiny assigned dbond09 Nov 14, 2022

mountiny approved these changes Nov 14, 2022

View reviewed changes

mountiny merged commit f5c11e8 into Expensify:main Nov 14, 2022

melvin-bot Bot added the Emergency label Nov 14, 2022

mountiny removed the Emergency label Nov 14, 2022

OSBotify mentioned this pull request Nov 15, 2022

Deploy Checklist: New Expensify 2022-11-15 #12753

Closed

31 tasks

melvin-bot Bot mentioned this pull request Nov 17, 2022

[PAID][$500] NewDot App scroll is 2-3x faster than other apps #10654

Closed

Uh oh!

Conversation

dbond09 commented Nov 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

Uh oh!

github-actions Bot commented Nov 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

dbond09 commented Nov 9, 2022

Uh oh!

Santhosh-Sellavel Nov 13, 2022

Choose a reason for hiding this comment

Uh oh!

dbond09 Nov 13, 2022

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel Nov 13, 2022

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Santhosh-Sellavel commented Nov 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Nov 14, 2022

Uh oh!

mountiny commented Nov 14, 2022

Uh oh!

OSBotify commented Nov 14, 2022

Uh oh!

roryabraham commented Nov 15, 2022

Uh oh!

mountiny commented Nov 15, 2022

Uh oh!

OSBotify commented Nov 15, 2022

Uh oh!

OSBotify commented Nov 15, 2022

Uh oh!

OSBotify commented Nov 17, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dbond09 commented Nov 9, 2022 •

edited

Loading

github-actions Bot commented Nov 9, 2022 •

edited

Loading

Santhosh-Sellavel commented Nov 14, 2022 •

edited

Loading