Skip to content

Add character limit error for edit composer #11986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 4 commits into from
Oct 24, 2022
Merged

Add character limit error for edit composer #11986

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
15ea4cc
add character limit error
Puneet-here Oct 20, 2022
4d5ab69
disable saving the comment when character limit has exceeded
Puneet-here Oct 20, 2022
56fab6d
use red border when in error state
Puneet-here Oct 20, 2022
a726968
move comment exceed logic to publishDraft
Puneet-here Oct 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/pages/home/report/ReportActionItemMessageEdit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ import EmojiPickerButton from '../../../components/EmojiPicker/EmojiPickerButton
import * as ReportActionContextMenu from './ContextMenu/ReportActionContextMenu';
import VirtualKeyboard from '../../../libs/VirtualKeyboard';
import reportPropTypes from '../../reportPropTypes';
import ExceededCommentLength from '../../../components/ExceededCommentLength';
import CONST from '../../../CONST';

const propTypes = {
/** All the data of the action */
Expand Down Expand Up @@ -131,6 +133,11 @@ class ReportActionItemMessageEdit extends React.Component {
* the new content.
*/
publishDraft() {
// Do nothing if draft exceed the character limit
if (this.state.draft.length > CONST.MAX_COMMENT_LENGTH) {
return;
}

// To prevent re-mount after user saves edit before debounce duration (example: within 1 second), we cancel
// debounce here.
this.debouncedSaveDraft.cancel();
Expand Down Expand Up @@ -186,9 +193,10 @@ class ReportActionItemMessageEdit extends React.Component {
}

render() {
const hasExceededMaxCommentLength = this.state.draft.length > CONST.MAX_COMMENT_LENGTH;
return (
<View style={styles.chatItemMessage}>
<View style={[styles.chatItemComposeBox, styles.flexRow, styles.chatItemComposeBoxColor]}>
<View style={[styles.chatItemComposeBox, styles.flexRow, styles.chatItemComposeBoxColor, hasExceededMaxCommentLength && styles.borderColorDanger]}>
<Composer
multiline
ref={(el) => {
Expand Down Expand Up @@ -235,11 +243,13 @@ class ReportActionItemMessageEdit extends React.Component {
<Button
small
success
isDisabled={hasExceededMaxCommentLength}
nativeID={this.saveButtonID}
style={[styles.mr2]}
onPress={this.publishDraft}
text={this.props.translate('common.saveChanges')}
/>
<ExceededCommentLength commentLength={this.state.draft.length} />
</View>
</View>
);
Expand Down