Skip to content

fix crash after login while trying to open profile details URL #11849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Beamanator merged 3 commits into from
Oct 20, 2022
Merged

fix crash after login while trying to open profile details URL #11849

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b26bc1
fix crash after login whiile trying to open profile details URL
aimane-chnaif Oct 14, 2022
787e4f1
set personalDetails optional on DetailsPage
aimane-chnaif Oct 18, 2022
e1f1c14
Update comment
aimane-chnaif Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/pages/DetailsPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,19 @@ const propTypes = {
/* Onyx Props */

/** The personal details of the person who is logged in */
personalDetails: personalDetailsPropType.isRequired,
personalDetails: personalDetailsPropType,

/** Route params */
route: matchType.isRequired,

...withLocalizePropTypes,
};

const defaultProps = {
// When opening someone else's profile (via deep link) before login, this is empty
personalDetails: {},
};

/**
* Gets the phone number to display for SMS logins
*
Expand Down Expand Up @@ -77,7 +82,7 @@ class DetailsPage extends React.PureComponent {
}

render() {
const details = this.props.personalDetails[lodashGet(this.props.route.params, 'login')];
const details = lodashGet(this.props.personalDetails, lodashGet(this.props.route.params, 'login'));
if (!details) {
// Personal details have not loaded yet
return <FullscreenLoadingIndicator />;
Expand Down Expand Up @@ -202,6 +207,7 @@ class DetailsPage extends React.PureComponent {
}

DetailsPage.propTypes = propTypes;
DetailsPage.defaultProps = defaultProps;

export default compose(
withLocalize,
Expand Down