Skip to content

Add auto focus to paypal.me field #11140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgolen merged 6 commits into from
Sep 22, 2022
Merged

Add auto focus to paypal.me field #11140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b06a3a3
auto focus paypal field
Puneet-here Sep 21, 2022
54ac78e
remove ref declaration
Puneet-here Sep 21, 2022
1624b83
remove ref declaration from password page
Puneet-here Sep 21, 2022
3a1180e
create a method for auto focus
Puneet-here Sep 22, 2022
6713bd8
remove inline callback
Puneet-here Sep 22, 2022
3cd5879
remove the comment
Puneet-here Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/pages/settings/AddSecondaryLoginPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,6 @@ class AddSecondaryLoginPage extends Component {
this.submitForm = this.submitForm.bind(this);
this.onSecondaryLoginChange = this.onSecondaryLoginChange.bind(this);
this.validateForm = this.validateForm.bind(this);

this.phoneNumberInputRef = null;
}

componentWillUnmount() {
Expand Down
1 change: 0 additions & 1 deletion src/pages/settings/PasswordPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,6 @@ class PasswordPage extends Component {
this.getErrorText = this.getErrorText.bind(this);
this.validate = this.validate.bind(this);
this.clearErrorAndSetValue = this.clearErrorAndSetValue.bind(this);
this.currentPasswordInputRef = null;

this.errorKeysMap = {
currentPassword: 'passwordPage.errors.currentPassword',
Expand Down
12 changes: 11 additions & 1 deletion src/pages/settings/Payments/AddPayPalMePage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ class AddPayPalMePage extends React.Component {
payPalMeUsernameError: false,
};
this.setPayPalMeUsername = this.setPayPalMeUsername.bind(this);
this.focusPayPalMeInput = this.focusPayPalMeInput.bind(this);
}

/**
Expand All @@ -57,9 +58,17 @@ class AddPayPalMePage extends React.Component {
Navigation.navigate(ROUTES.SETTINGS_PAYMENTS);
}

focusPayPalMeInput() {
if (!this.payPalMeInputRef) {
return;
}

this.payPalMeInputRef.focus();
}

render() {
return (
<ScreenWrapper>
<ScreenWrapper onTransitionEnd={this.focusPayPalMeInput}>
<HeaderWithCloseButton
title={this.props.translate('common.payPalMe')}
shouldShowBackButton
Expand All @@ -72,6 +81,7 @@ class AddPayPalMePage extends React.Component {
{this.props.translate('addPayPalMePage.enterYourUsernameToGetPaidViaPayPal')}
</Text>
<TextInput
ref={el => this.payPalMeInputRef = el}
label={this.props.translate('addPayPalMePage.payPalMe')}
autoCompleteType="off"
autoCorrect={false}
Expand Down