Skip to content

OptionsSelector - Fix console error #10763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgolen merged 3 commits into from
Sep 8, 2022
Merged

OptionsSelector - Fix console error #10763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66c5772
fix localize console error
rushatgabhane Sep 1, 2022
e31d2e8
Merge branch 'Expensify:main' into fix-console-error
rushatgabhane Sep 1, 2022
ecde6fa
Merge branch 'Expensify:main' into fix-console-error
rushatgabhane Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/OptionsSelector/BaseOptionsSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import Text from '../Text';
import compose from '../../libs/compose';
import CONST from '../../CONST';
import styles from '../../styles/styles';
import withLocalize from '../withLocalize';
import withLocalize, {withLocalizePropTypes} from '../withLocalize';
import TextInput from '../TextInput';
import ArrowKeyFocusManager from '../ArrowKeyFocusManager';
import KeyboardShortcut from '../../libs/KeyboardShortcut';
Expand All @@ -24,6 +24,7 @@ const propTypes = {
shouldDelayFocus: PropTypes.bool,

...optionsSelectorPropTypes,
...withLocalizePropTypes,
};

const defaultProps = {
Expand Down
3 changes: 0 additions & 3 deletions src/components/OptionsSelector/optionsSelectorPropTypes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import PropTypes from 'prop-types';
import optionPropTypes from '../optionPropTypes';
import {withLocalizePropTypes} from '../withLocalize';
import styles from '../../styles/styles';

const propTypes = {
Expand Down Expand Up @@ -93,8 +92,6 @@ const propTypes = {

/** Whether to show options list */
shouldShowOptions: PropTypes.bool,

...withLocalizePropTypes,
};

const defaultProps = {
Expand Down