Fix scrolling on mobile#107
Conversation
| sidebarFooterAvatar: { | ||
| backgroundColor: colors.text, | ||
| borderRadius: '50%', | ||
| borderRadius: 20, |
There was a problem hiding this comment.
@shawnborton - borderRadius can only be a number, so had to divide height/width by 2 manually.
| height: 40, | ||
| justifyContent: 'center', | ||
| textDecoration: 'none', | ||
| textDecorationLine: 'none', |
There was a problem hiding this comment.
We were just missing Line on this one
| borderTopWidth: 1, | ||
| borderTopColor: colors.border, | ||
| minHeight: '85', | ||
| minHeight: 85, |
There was a problem hiding this comment.
String -> Number
|
How do all of these changes look on web? Especially the ellipsis truncation changes? |
|
Fixed in db823f7 |
|
Here is how it looks with the latest changes:
|
|
Sweet! Last thing - should we address the scroll bar issue you are having? I am curious why you don't get it on the main chat window but you have it on the list item container. Looks like the main chat area has |
|
Ok I fixed the scroll bar issue 😻
However, one thing to note.. I don't think it scrolls when it has more than a few reports (on this PR or |
|
Well as long as the |
|
On web, yes, but on mobile it doesn't seem to scroll the same. Also for the POC we only fetch 10 reports on dev, so I don't know if it will ever be an issue. |
|
Ah, got it. Okay, sounds good to me then! |
Co-authored-by: Tim Golen <tgolen@expensify.com>
split navigators performance
Closes #78 and #77
@tgolen @shawnborton - I had to remove some code, but I verified this works on local mobile/web.