[NO QA]Ignore all PropTypes.arrayOf(PropTypes.object) - #10448
Merged
Conversation
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
melvin-bot
Bot
requested review from
NikkiWines
and removed request for
a team
August 18, 2022 15:57
Contributor
Author
|
I tried tweaking the |
luacmartins
approved these changes
Aug 18, 2022
luacmartins
left a comment
Contributor
There was a problem hiding this comment.
LGTM thanks for fixing this!
Contributor
|
Merging to fix linting issues in App! |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
48 tasks
Contributor
|
🚀 Deployed to staging by @luacmartins in version: 1.1.89-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
It seems like some other change upgraded lint to now check for
PropTypes.arrayOf(PropTypes.object)as beingforbid-prop-types. This ignores all of those prop types to make lint pass.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/223483
Tests