Refactor WorkspaceInitialPage to no longer use withFullPolicy - #10444
Conversation
arosiclair
left a comment
There was a problem hiding this comment.
Aside from withFullPolicy removal, everything else looks good!
|
|
||
| export default compose( | ||
| withLocalize, | ||
| withFullPolicy, |
There was a problem hiding this comment.
Sorry for the confusion, but we're no longer looking to remove withFullPolicy completely. Instead, we'll just be updating it to not fetch policy data so you can keep it here
There was a problem hiding this comment.
Hmmm... Yes, I am confused 😅 . Do we need withFullPolicy here - why keep it? Also, the withFullPolicy code is still loading the full policy - when are we removing that?
There was a problem hiding this comment.
So withFullPolicy also tracks the last visited workspace/policy so we shouldn't remove that functionality.
We'll remove the policy loading with this GH but this is only safe to do once all the other refactors are done (if we do it before, these pages will have no data).
There was a problem hiding this comment.
Okay great - makes sense thanks for clarifying!
|
Updated and retested! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @arosiclair in version: 1.1.89-0 🚀
|
@arosiclair Please review
Details
Refactor WorkspaceInitialPage to no longer use
withFullPolicyand use theFullPageNotFoundViewinstead.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/218369
Tests/QA
https://user-images.githubusercontent.com/4741899/185338389-1b69cfd1-4bf9-424d-934d-06635a312134.mp4
https://user-images.githubusercontent.com/4741899/185338667-4492d192-998d-4676-a362-42a92a39e2d4.mp4