PropType error when opening Payments page. (dev only)

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Login
2. Navigate to Settings > Payments

Expected Result:

Page should open without any error

Actual Result:

PropType error when opening Payments page. (dev only)

Workaround:

unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.1.79-0
Reproducible in staging?: N
Reproducible in production?: N
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1657052974042869

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[danieldoglas]

Interesting. This looks like a bug on importing withLocalizePropTypes. Trying to find what could be happening

[parasharrajat]

I looked into this and the issue is that

App/src/pages/settings/Payments/PaymentsPage/BasePaymentsPage.js

Line 329 in 046a8b6

title={this.state.formattedSelectedPaymentMethod.title}

throws a warning only when the page is opened for the first time after login.

This happens as formattedSelectedPaymentMethod state is initialized with empty object and formattedSelectedPaymentMethod.title is undefined until user selects a payment method from the UI.

To fix this:

1. Initialize the state formattedSelectedPaymentMethod with {title: ''}

I will send a PR shortly...

[parasharrajat]

I also fixed one more prop warning on this page.

[melvin-bot]

Triggered auto assignment to @mallenexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[danieldoglas]

@parasharrajat should be assigned to this job.

[danieldoglas]

@mallenexpensify is OOO, I'll remove him and add the tag again.