Android - Add payment card button opens not here page

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.34-0
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #84049
Email or phone of affected tester (no customers): sidbhisdhidhisdhis@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Samsung Galaxy S25 FE / Android 16
App Component: Other

Action Performed:

1. Launch Expensify app.
2. Log in to an existing account without payment card that has at least one workspace.
3. Kill and relaunch app.
4. Tap Add payment card button on free trial modal.

Expected Result:

Subscription page will open.

Actual Result:

Not here page opens.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7207966_1784029573687.Screen_Recording_20260714_194400_Expensify.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7207966

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #84049

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/eb7da5815b9a59db1960d1c77dbce61ae8d9b5b93bb964be5acc3b583f9b22c5

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On Android (native), tapping Add payment card in the new free-trial countdown pop-up opens the "Not here" page instead of the Subscription page.

What is the root cause of that problem?

The new TrialPaymentReminderModalManager (added in #84049) navigates directly to ROUTES.SETTINGS_SUBSCRIPTION_ADD_PAYMENT_CARD on every platform:

src/components/TrialPaymentReminderModalManager.tsx:32-36

But adding a payment card is web-only. On native, that route intentionally renders a full-page NotFound ("Not here"):

src/pages/settings/Subscription/PaymentCard/index.native.tsx:6-16 — always returns <FullPageNotFoundView shouldShow />.

The codebase already has a platform-aware helper for exactly this, which the new code bypassed. On native it routes to the Subscription root instead of the add-payment-card route:

src/pages/home/common/navigateToSubscriptionPayment/index.native.tsx — "Adding payment card is currently only available on web" → navigates to ROUTES.SETTINGS_SUBSCRIPTION.route.

This matches the issue's Expected Result exactly ("Subscription page will open").

What changes do you think we should make in order to solve the problem?

In TrialPaymentReminderModalManager.tsx, replace the direct Navigation.navigate(ROUTES.SETTINGS_SUBSCRIPTION_ADD_PAYMENT_CARD) call with the existing platform-aware helper navigateToSubscriptionPayment (src/pages/home/common/navigateToSubscriptionPayment). This automatically sends native users to the Subscription root while keeping the web deep-link to the add-payment-card page.

Suggested diff

- import Navigation from '@libs/Navigation/Navigation';
- ...
- import ROUTES from '@src/ROUTES';
+ import navigateToSubscriptionPayment from '@pages/home/common/navigateToSubscriptionPayment';

  const handleAddPaymentCard = useCallback(() => {
      setIsModalOpen(false);
      dismiss();
-     Navigation.navigate(ROUTES.SETTINGS_SUBSCRIPTION_ADD_PAYMENT_CARD);
+     navigateToSubscriptionPayment();
  }, [dismiss]);

(Remove the now-unused Navigation/ROUTES imports if nothing else needs them.)

What alternative solutions did you explore?

None needed — the platform split already exists and is the established pattern (also used by CardSection). Simply reusing it fixes the deploy blocker with minimal, consistent code.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement this to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[shubham1206agra]

@MelvinBot implement this