Problem
After every deploy, a bot comments on each shipped PR with "Bundle Size Analysis" links. Those links are broken — there are extra characters on the end of the address — so clicking one goes to an error page instead of the size report.
Reproduction Steps
These apply to any staging or production deploy.
- Wait for a deploy to finish.
- Open any PR that was included in that deploy.
- In the automated deploy comment, click one of the links under "Bundle Size Analysis (Sentry)".
Expected Behavior: The link opens the Sentry bundle size analysis page for that build.
Actual Behavior: The link goes to an error page, because a trailing "} is stuck onto the end of the address.
Example: see the deploy comment on App#94322 — both Sentry links at the bottom are dead.
Solution
The Android and iOS build workflows pull the link out of the upload tool's logs with a pattern that grabs everything up to the next space, so the surrounding punctuation gets pulled in too. Restrict the match so it stops at the quote/brace.
Extra context
Surfaced while investigating a staging deploy whose postDeployComments job failed. The broken links are unrelated to that failure — they show up on every deploy comment.
Root cause is in .github/workflows/buildAndroid.yml and .github/workflows/buildIOS.yml: grep -oE 'https://expensify\.sentry\.io/[^ ]+' matches up to the next space, so when sentry-cli prints the URL inside JSON ({"url":"...343209"}) the trailing "} is captured. The fix changes the class to [^ "}]+.
– written by Claude on Ben's behalf
Problem
After every deploy, a bot comments on each shipped PR with "Bundle Size Analysis" links. Those links are broken — there are extra characters on the end of the address — so clicking one goes to an error page instead of the size report.
Reproduction Steps
These apply to any staging or production deploy.
Expected Behavior: The link opens the Sentry bundle size analysis page for that build.
Actual Behavior: The link goes to an error page, because a trailing
"}is stuck onto the end of the address.Example: see the deploy comment on App#94322 — both Sentry links at the bottom are dead.
Solution
The Android and iOS build workflows pull the link out of the upload tool's logs with a pattern that grabs everything up to the next space, so the surrounding punctuation gets pulled in too. Restrict the match so it stops at the quote/brace.
Extra context
Surfaced while investigating a staging deploy whose postDeployComments job failed. The broken links are unrelated to that failure — they show up on every deploy comment.
Root cause is in
.github/workflows/buildAndroid.ymland.github/workflows/buildIOS.yml:grep -oE 'https://expensify\.sentry\.io/[^ ]+'matches up to the next space, so whensentry-cliprints the URL inside JSON ({"url":"...343209"}) the trailing"}is captured. The fix changes the class to[^ "}]+.– written by Claude on Ben's behalf