[Due for payment 2026-07-17] [$250] Disabled report fields continue to appear in the "Recent" section when creating reports

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.

---

Version Number: 9.4.17-3
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from BrowserStack:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @BuhusLucian
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Create a workspace report field.
2. Use the report field on one or more reports.
3. Disable the report field in workspace settings.
4. Create a new report or edit an existing report.
5. Open the report field selector and review the Recent section.

Expected Result:

Disabled report fields should not appear anywhere in the report field selection UI, including the Recent section.
Only active/enabled report fields should be displayed.

Actual Result:

The disabled report field is still displayed under Recent, even though it has been disabled and is no longer available for use.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Recording.3072.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022069542676150326761
• Upwork Job ID: 2069542676150326761
• Last Price Increase: 2026-06-23

Issue Owner

Current Issue Owner: @mallenexpensify

[MelvinBot]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Disabled report field list values still appear under the Recent section of the report-field value selector, even though they are correctly excluded from the All section. Only enabled values should be selectable anywhere in the picker.

What is the root cause of that problem?

The selector renders two sources of values. The All list is built from fieldOptions, which is already filtered to exclude disabled values in DynamicEditReportFieldPage.tsx:210:

fieldOptions={policyField.values.filter((_value, index) => !policyField.disabledOptions.at(index))}

The Recent list, however, is read straight from Onyx (recentlyUsedReportFields) in EditReportFieldDropdown.tsx:26-45 and passed into getReportFieldOptionsSection, where the only filter applied is removing already-selected keys — there is no intersection with the enabled options. See ReportFieldOptionsListUtils.ts:54:

const filteredRecentlyUsedOptions = recentlyUsedOptions.filter((o) => !selectedKeySet.has(o));

So a value that was used before being disabled stays in recentlyUsedReportFields and reappears under Recent, while being correctly absent from All.

What changes do you think we should make in order to solve the problem?

Constrain the Recent section to values that are still enabled by intersecting recentlyUsedOptions with the (already disabled-filtered) options. In ReportFieldOptionsListUtils.ts:54:

const enabledOptionSet = new Set(options);
const filteredRecentlyUsedOptions = recentlyUsedOptions.filter((o) => !selectedKeySet.has(o) && enabledOptionSet.has(o));

Because options arriving here is already filtered to enabled values (DynamicEditReportFieldPage.tsx:210), this guarantees Recent can never contain a disabled value, with no extra data plumbing. The same enabledOptionSet check also safely drops any stale recent value that no longer exists on the field at all.

Data flow & evidence

• values / disabledOptions are parallel arrays on a list report field — index i of disabledOptions marks values[i] disabled (Policy.ts:1875-1884).
• DynamicEditReportFieldPage filters disabled values out of fieldOptions → passed to EditReportFieldDropdown.
• EditReportFieldDropdown reads recentlyUsedReportFields[fieldKey] raw from Onyx (no disabled filter) and passes both into getReportFieldOptionsSection.
• getReportFieldOptionsSection puts filtered options into All but builds Recent from recentlyUsedOptions with only a selected-key filter (ReportFieldOptionsListUtils.ts:66-73) → disabled value leaks into Recent.

Alternative considered: filtering recentlyUsedOptions inside EditReportFieldDropdown before the call. Functionally equivalent, but doing it in getReportFieldOptionsSection keeps the invariant ("Recent ⊆ enabled options") co-located with where the sections are assembled and covers all callers.

What alternative solutions did you explore? (Optional)

Pruning disabled values from recentlyUsedReportFields in Onyx at disable time was considered but rejected — it adds write-path complexity and wouldn't retroactively fix already-stored data; filtering at render time is simpler and self-healing.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94372) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.

[ahmdshrif]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When you open the value selector for a list report field (creating or editing a report), the Recent section still lists option values that have been disabled in the workspace report-field settings. Disabled values should not be selectable anywhere, including Recent — only the (correctly filtered) All section currently hides them.

What is the root cause of that problem?

The selector builds two lists from two different sources, and only one of them is filtered for disabled options.

1. The caller passes fieldOptions to the dropdown already filtered to enabled values — it drops every value whose parallel disabledOptions[index] flag is true:
   

   App/src/pages/DynamicEditReportFieldPage.tsx

   Lines 206 to 213 in e89af71

   	{reportField.type === CONST.REPORT_FIELD_TYPES.LIST && (
   	<EditReportFieldDropdown
   	fieldKey={fieldKey}
   	fieldValue={fieldValue}
   	fieldOptions={policyField.values.filter((_value: string, index: number) => !policyField.disabledOptions.at(index))}
   	onSubmit={handleReportFieldChange}
   	/>
   	)}

   
   (values and disabledOptions are parallel arrays on the policy field:

   App/src/types/onyx/Policy.ts

   Lines 1875 to 1884 in e89af71

   	values: string[];
   	/** Tax UDFs have keys holding the names of taxes (eg, VAT), values holding percentages (eg, 15%) and a value indicating the currently selected tax value (eg, 15%). */
   	keys: string[];
   	/** list of externalIDs, this are either imported from the integrations or auto generated by us, each externalID */
   	externalIDs: string[];
   	/** Collection of flags that state whether drop down field options are disabled */
   	disabledOptions: boolean[];

   )

2. But the Recent list is read straight from the per-user Onyx NVP recentlyUsedReportFields[fieldKey] with no disabled filter applied:
   

   App/src/pages/EditReportFieldDropdown.tsx

   Lines 26 to 29 in e89af71

   	const [recentlyUsedReportFields] = useOnyx(ONYXKEYS.RECENTLY_USED_REPORT_FIELDS);
   	const [searchValue, debouncedSearchValue, setSearchValue] = useDebouncedState('');
   	const {translate, localeCompare} = useLocalize();
   	const recentlyUsedOptions = recentlyUsedReportFields?.[fieldKey]?.sort(localeCompare) ?? [];

3. getReportFieldOptionsSection then renders the two sections independently: the All section is built from the filtered options, while the Recent section is built from the unfiltered recentlyUsedOptions (only de-duped against the currently selected value):
   

   App/src/libs/ReportFieldOptionsListUtils.ts

   Lines 54 to 73 in e89af71

   	const filteredRecentlyUsedOptions = recentlyUsedOptions.filter((o) => !selectedKeySet.has(o));
   	const filteredOptions = options.filter((o) => !selectedKeySet.has(o));
   	if (selectedOptionKeys.length) {
   	reportFieldOptionsSections.push({
   	// "Selected" section
   	title: '',
   	sectionIndex: 1,
   	data: getReportFieldOptions(selectedOptionKeys, selectedKeySet),
   	});
   	}
   	if (filteredRecentlyUsedOptions.length > 0) {
   	reportFieldOptionsSections.push({
   	// "Recent" section
   	title: translate('common.recent'),
   	sectionIndex: 2,
   	data: getReportFieldOptions(filteredRecentlyUsedOptions),
   	});
   	}

So the structural cause is a missing disabled-filter on the Recent source: because a value only lands in recentlyUsedReportFields after it has been used on a report, the repro path (use a value → disable it) leaves it in the NVP, and Recent keeps showing it while All correctly hides it. This matches every symptom detail: the value appears only under Recent, only after it was used, and survives being disabled.

This is the only render path affected: getReportFieldOptionsSection has a single consumer (EditReportFieldDropdown), and the sibling list-value picker in workspace settings already filters disabled values itself (...filter((listValue, index) => !disabledOptions.at(index))), so it does not show disabled values:

App/src/pages/workspace/reports/InitialListValueSelector/ReportFieldsInitialListValuePicker.tsx

Lines 21 to 28 in e89af71

	const {localeCompare} = useLocalize();
	const listValueOptions = useMemo(
	() =>
	Object.values(listValues ?? {})
	.filter((listValue, index) => !disabledOptions.at(index))
	.sort(localeCompare)
	.map((listValue) => ({
	keyForList: listValue,

What changes do you think we should make in order to solve the problem?

In EditReportFieldDropdown, intersect the recently-used values with the already-enabled fieldOptions before passing them to getReportFieldOptionsSection:

const validFieldOptions = fieldOptions?.filter((option) => !!option)?.sort(localeCompare);
const enabledOptionSet = new Set(validFieldOptions);
const recentlyUsedOptions = (recentlyUsedReportFields?.[fieldKey] ?? [])
    .filter((option) => enabledOptionSet.has(option))
    .sort(localeCompare);

fieldOptions is the single source of truth for which values are currently selectable (it already encodes disabledOptions), so reusing it keeps Recent and All consistent by construction. As a bonus it also prunes from Recent any value that was deleted from the field, not just disabled ones. Regression safety: this only narrows the Recent list to values already shown in All — the All section, selected value, search, and save flow are untouched.

Why the obvious one-line fix does not work: pruning the value from recentlyUsedReportFields inside the disable action (Policy/ReportField.ts) looks simpler but is wrong — recentlyUsedReportFields is a per-user NVP, so an admin disabling a policy-level value cannot (and the backend does not) rewrite every member's recent list; the stale value would persist client-side until the next sync, and re-enabling the value would not restore it to Recent. The codebase already handles this class of problem with render-time filtering (line 210 above, and the sibling picker), so filtering at render is the consistent, complete fix.

What alternative solutions did you explore? (Optional)

1. Filter inside getReportFieldOptionsSection by passing disabledOptions/the enabled set into the util. Works, but the util is generic over a flat string[] and has one caller, so threading the disabled state in adds surface area for no extra coverage — filtering at the call site is tighter.
2. Prune the NVP on disable (the obvious spot-fix) — incomplete for the reasons above (per-user NVP, no re-enable restore, sync-dependent); it also misses the deleted-value case.

[lorretheboy]

Proposal

What is the root cause of that problem?

When the report-field dropdown is opened, the options (enabled values) are pre-filtered to remove disabled options before reaching getReportFieldOptionsSection, but the recentlyUsedOptions are taken straight from Onyx and are never cross-checked against that enabled set.

fieldOptions is filtered against disabledOptions before being passed in:

App/src/pages/DynamicEditReportFieldPage.tsx

Lines 206 to 213 in e89af71

	{reportField.type === CONST.REPORT_FIELD_TYPES.LIST && (
	<EditReportFieldDropdown
	fieldKey={fieldKey}
	fieldValue={fieldValue}
	fieldOptions={policyField.values.filter((_value: string, index: number) => !policyField.disabledOptions.at(index))}
	onSubmit={handleReportFieldChange}
	/>
	)}

…while recentlyUsedOptions comes unfiltered from RECENTLY_USED_REPORT_FIELDS:

App/src/pages/EditReportFieldDropdown.tsx

Lines 26 to 45 in e89af71

	const [recentlyUsedReportFields] = useOnyx(ONYXKEYS.RECENTLY_USED_REPORT_FIELDS);
	const [searchValue, debouncedSearchValue, setSearchValue] = useDebouncedState('');
	const {translate, localeCompare} = useLocalize();
	const recentlyUsedOptions = recentlyUsedReportFields?.[fieldKey]?.sort(localeCompare) ?? [];
	const validFieldOptions = fieldOptions?.filter((option) => !!option)?.sort(localeCompare);
	const sections = getReportFieldOptionsSection({
	searchValue: debouncedSearchValue,
	selectedOptions: [
	{
	keyForList: fieldValue,
	searchText: fieldValue,
	text: fieldValue,
	},
	],
	options: validFieldOptions,
	recentlyUsedOptions,
	translate,
	});

Inside getReportFieldOptionsSection, the "Recent" list is filtered only to drop the already-selected value, not to drop disabled values, whereas the "All" list is built from the already-filtered options:

App/src/libs/ReportFieldOptionsListUtils.ts

Lines 54 to 55 in e89af71

	const filteredRecentlyUsedOptions = recentlyUsedOptions.filter((o) => !selectedKeySet.has(o));
	const filteredOptions = options.filter((o) => !selectedKeySet.has(o));

So a value that was recently used and then disabled survives in filteredRecentlyUsedOptions and is rendered under "Recent":

App/src/libs/ReportFieldOptionsListUtils.ts

Lines 66 to 73 in e89af71

	if (filteredRecentlyUsedOptions.length > 0) {
	reportFieldOptionsSections.push({
	// "Recent" section
	title: translate('common.recent'),
	sectionIndex: 2,
	data: getReportFieldOptions(filteredRecentlyUsedOptions),
	});
	}

What changes do you think we should make in order to solve the problem?

Filter the recently-used list against the enabled options set as well, so disabled values can never appear under "Recent". Update the filteredRecentlyUsedOptions line here:

App/src/libs/ReportFieldOptionsListUtils.ts

Line 54 in e89af71

const filteredRecentlyUsedOptions = recentlyUsedOptions.filter((o) => !selectedKeySet.has(o));

so it keeps only options that are also present in the enabled options array (e.g. build a Set from options and require optionsSet.has(o) in addition to !selectedKeySet.has(o)). This fixes it at the single shared convergence point, so every caller of getReportFieldOptionsSection benefits.

What alternative solutions did you explore? (Optional)

Filter recentlyUsedOptions against disabledOptions at the call site in EditReportFieldDropdown before passing them down. This works but only fixes this one entry point and duplicates filtering logic, so fixing the shared util is preferable.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[aswin-s]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022069542676150326761

[kitvasyl]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

[github-actions]

⚠️ @lorretheboy Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).