[Due for payment 2026-07-13] Spend rule - No results appear when searching by valid currency name

[applause-bot]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.4.16-1
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #93063
Email or phone of affected tester (no customers): applausetester+khcategory19@applause.expensifail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.5 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Enable Expensify card and Rules.
• Workspace has at least one virtual Expensify card.

1. Go to staging.new.expensify.com
2. Open FAB > Create expense > Manual.
3. Click Currency.
4. Type singapore.
   → User can search for currency by typing currency name.
5. Go to workspace settings > Rules.
6. Click Add spend rule.
7. Click Choose cards and select a card.
8. Click Permitted currencies.
9. Type singapore.

Expected Result:

Currency will appear when searching by valid currency name.

Actual Result:

No results appear when searching by valid currency name.

There is also no "No results found" message in empty result screen.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome Safari

Screenshots/Videos

Bug7185663_1781886596313.5.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Nathan Lemma
Bug ID: 7185663

[applause-bot]

While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/476dc658a7fc81bb1d160721668b0416bbc70965a35a1948aafe642fa59c8726

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #93063

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[MelvinBot]

Proposal

What is the root cause of that problem?

The spend-rule "Permitted currencies" search only matches against each row's text — which is the currency code + symbol (e.g. "SGD - $"), never the currency name. So typing singapore matches nothing.

getCurrencyOptions returns the currency name in a separate searchableText field, not in text:

Evidence

• SearchUIUtils.ts:4803 builds each option as {text: "${code} - ${symbol}", value: code, searchableText: name}. The name ("Singapore Dollar") lives only in searchableText.
• SpendRulesCurrencyBase.tsx:69-74 copies only text/value into its list items and drops searchableText.
• SpendRulesCurrencyBase.tsx:81-83 filters on item.text only.

The working manual-expense picker uses CurrencySelectionList, which filters on both fields — CurrencySelectionList/index.tsx:56-60: searchRegex.test(text) || searchRegex.test(currencyName). That's why search-by-name works there but not here.

The second symptom (no "No results found" message) has the same source: SpendRulesCurrencyBase never passes a headerMessage to its SelectionList, whereas CurrencySelectionList renders an empty state via its isEmpty flag.

Introduced by #93063, which added this brand-new picker rather than reusing CurrencySelectionList.

What changes do you think we should make in order to solve the problem?

In SpendRulesCurrencyBase.tsx:

1. Carry the currency name onto each list item — add searchableText: currencyOption.searchableText when building currencyItems (around line 69-74), and add the field to the CurrencyListItem type.
2. Update filterCurrency (line 81-83) to also match the name, e.g. (item.text ?? '').toLowerCase().includes(searchInput) || (item.searchableText ?? '').toLowerCase().includes(searchInput).
3. Pass a headerMessage to the SelectionList so an empty search shows the standard message — headerMessage={inputValue.trim() && filteredCurrencyItems.length === 0 ? translate('common.noResultsFound') : ''}.

What alternative solutions did you explore? (Optional)

Replace the bespoke list with the shared CurrencySelectionList component (used by the manual picker), which already handles name search and the empty state — larger change, riskier for a deploy blocker.

---

Next Steps for Contributor+ team:
To accept: @MelvinBot implement [this](https://github.com/Expensify/App/issues/94091) to create a draft PR.
To refine: @MelvinBot <your feedback>
To reject: Explain why you are rejecting Melvin's proposal.