[Due for payment 2026-05-26] [Due for payment 2026-05-26] [$250] Invoice - Merchant field cannot be cleared when inline editing invoice

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.75-6
Reproducible in staging?: Yes
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #89166
Email or phone of affected tester (no customers): sojdnosjdosjoisjg@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Enable Invoices in workspace settings > More features.

1. Go to staging.new.expensify.com
2. Go to Spend tab.
3. Open FAB > Send invoice.
4. Send an invoice with merchant to any user.
5. Click on the inline merchant field on the expense row.
6. Clear merchant and hit Enter.

Expected Result:

Merchant field can be cleared when inline editing invoice (merchant is not a requirement for invoice).

Actual Result:

Merchant field cannot be cleared when inline editing invoice.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7157242_1779119690538.18.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022056429463060490551
• Upwork Job ID: 2056429463060490551
• Last Price Increase: 2026-05-18

Issue Owner

Current Issue Owner: @ahmedGaber93

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #89166

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[OSBotify]

Investigation Summary

Classification: Frontend bug
Causing PR: #89166 - "feat: Add inline editing for tables on desktop (V2)" by @mohammadjafarinejad (High confidence)
Related Issues: #82534, #88711

Recommendation: REVERT

PR #89166 introduced the inline merchant editing feature for the Search/Expenses table. Its isValidMerchant validation does not allow clearing the merchant field on invoice reports, even though merchant is not required for invoices.

Assigned: @mohammadjafarinejad (PR author), @ahmedGaber93, @puneetlath (approving reviewers) from highest-confidence causing PR only
Labels: No label changes — DeployBlockerCash is appropriate since the fix requires reverting or patching an App PR. No DeployBlocker label was present to remove.

Detailed Analysis

Evidence

• The bug is staging-only (issue states "N/A - new feature, doesn't exist in prod"), reproduced on version 9.3.75-6.
• The issue body directly links to PR feat: Add inline editing for tables on desktop (V2) #89166 as the regression source. Melvin-bot also identified this PR.
• PR feat: Add inline editing for tables on desktop (V2) #89166 was merged on 2026-05-14 and is listed in the StagingDeployCash for this release cycle.
• PR feat: Add inline editing for tables on desktop (V2) #89166 added src/libs/actions/TransactionInlineEdit.ts which contains the editTransactionMerchantInline function that gates saves behind isValidMerchant.
• PR feat: Add inline editing for tables on desktop (V2) #89166 also introduced src/libs/MoneyRequestUtils.ts additions including the isValidMerchant function itself.

Verification

• Affected file: src/libs/actions/TransactionInlineEdit.ts — modified by PR feat: Add inline editing for tables on desktop (V2) #89166 (new file introduced by this PR).
• Affected file: src/libs/MoneyRequestUtils.ts — modified by PR feat: Add inline editing for tables on desktop (V2) #89166 (added isValidMerchant).
• The PR also modified src/components/TransactionItemRow/DataCells/MerchantCell.tsx, which is where the inline merchant editor renders.

Root Cause

In src/libs/MoneyRequestUtils.ts, the isValidMerchant function allows an empty/cleared merchant only when the transaction is unreported (isExpenseUnreported) or the parent report is an IOU (isIOUReport). However, invoice reports have report.type === CONST.REPORT.TYPE.INVOICE, which is a distinct value from CONST.REPORT.TYPE.IOU. The condition on line 177 (if (isEmpty && (isUnreported || isIOU))) does not cover the invoice case, so when a user clears the merchant on an invoice and hits Enter, isValidMerchant returns false, causing editTransactionMerchantInline to return early without saving. The fix needs to add || isInvoiceReport(report) to that condition, or the PR should be reverted.