[$250] Send Money - Incorrect chat conversation displayed after send money to non-existing account

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue was found when executing PR: https://github.com/Expensify/Web-Expensify/pull/33293

Action Performed:

1. Go to staging.new.expensify.com
2. Login and click on Send money
3. Put in an amount and tap Continue
4. Enter the email of a non-existing account
5. Select "I'll settle up elsewhere"

Expected Result:

Correct chat conversation displayed after send money to non-existing account

Actual Result:

Incorrect chat conversation displayed after send money to non-existing account

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.63.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers): any

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause

Bug5577109_Recording__642.mp4

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[iwiznia]

Oh wow... yes, terrible bug.

[melvin-bot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[thesahindia]

This bug isn't only about non-existing accounts. We just don't navigate to the report when a user sends money.

Proposal

When a user sends money payIOUReport gets called, inside the function after the api request we get two reports in the response the first one contains the reportID of the report that the user send money to we can just access that and we need to navigate user to that report.

To do this we can use this code -

            const userReportID = lodashGet(_.first(_.values(response.reports)), 'reportID', '');
            Navigation.navigate(ROUTES.getReportRoute(userReportID));

(not sure what should be the variable name)

After this -

App/src/libs/actions/IOU.js

Lines 312 to 325 in 11a1f0d

	if (response.jsonCode !== 200) {
	switch (response.message) {
	case 'You cannot pay via Expensify Wallet until you have either a verified deposit bank account or debit card.':
	Growl.error(Localize.translateLocal('bankAccount.error.noDefaultDepositAccountOrDebitCardAvailable'), 5000);
	break;
	case 'This report doesn\'t have reimbursable expenses.':
	Growl.error(Localize.translateLocal('iou.noReimbursableExpenses'), 5000);
	break;
	default:
	Growl.error(response.message, 5000);
	}
	Onyx.merge(ONYXKEYS.IOU, {error: true});
	return;
	}

[adelekennedy]

Internal
External