[Due for payment 2026-05-13] [Due for payment 2026-05-12] Categories - Spend category list opens not here page

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.66-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: #88842
Email or phone of affected tester (no customers): jsosdjosjndosjodnjno@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Mac 26.2 / Chrome
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Categories.
3. Click More > Settings.
4. Open any spend category.

Expected Result:

Category list will open.

Actual Result:

Not here page opens.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7144270_1777908053442.3.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

You have been assigned to this deploy blocker because you recently merged this PR: #88842

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[OSBotify]

🔍 Investigation Summary

Classification: Frontend bug
Causing PR: #88842 - "BT - Migrate Workspace Categories" by @mananjadhav (High confidence)
Related Issues: N/A

Recommendation: REVERT

PR #88842 renamed SCREENS.WORKSPACE.CATEGORIES_SETTINGS to SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGS throughout the codebase but missed updating the entryScreens array in DYNAMIC_ROUTES.SPEND_CATEGORY_SELECTOR in src/ROUTES.ts. This causes the dynamic route system to reject navigation to the spend category selector from the categories settings page, resulting in the "Not here" page.

Assigned: @mananjadhav (PR author), @huult @mjasikowski (approving reviewers) from highest-confidence causing PR only
Labels: Keeping DeployBlockerCash (frontend bug from App PR). Removing DeployBlocker (no backend involvement).

📋 Detailed Analysis

Evidence

• PR BT - Migrate Workspace Categories #88842 was merged on 2026-05-04 and is the last meaningful change to workspace categories navigation before this issue was reported.
• The melvin-bot already assigned this PR as the cause in the first comment.
• The PR's goal was to migrate workspace categories screens from static routes to dynamic routes (the "BT - Migrate" pattern).
• It correctly renamed SCREENS.WORKSPACE.CATEGORIES_SETTINGS → SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGS in the screen registry, navigator mapping, linking config, types, and WORKSPACE_TO_RHP relations.
• However, it missed one location: the entryScreens array of DYNAMIC_ROUTES.SPEND_CATEGORY_SELECTOR in src/ROUTES.ts (line 321).

Verification

Affected file: src/ROUTES.ts

The SPEND_CATEGORY_SELECTOR dynamic route at line 319–323 reads:

SPEND_CATEGORY_SELECTOR: {
    path: 'spend-category-selector/:groupID',
    entryScreens: [SCREENS.WORKSPACE.CATEGORIES_SETTINGS, ...],  // still uses OLD name
    ...
}

The entryScreens mechanism is enforced in src/libs/Navigation/helpers/getStateFromPath.ts: when a user navigates to the spend category selector, the dynamic route system checks whether the currently focused screen name matches any value in entryScreens. Since the screen is now named DYNAMIC_CATEGORIES_SETTINGS (new) but entryScreens still lists CATEGORIES_SETTINGS (old), the check fails and the "Not here" page is shown.

The page component (WorkspaceCategoriesSettingsPage.tsx) correctly navigates to createDynamicRoute(DYNAMIC_ROUTES.SPEND_CATEGORY_SELECTOR.getRoute(item.groupID)) on item select — the call-site is correct, but the route guard rejects it.

PR #88842 modifies WorkspaceCategoriesSettingsPage.tsx and src/ROUTES.ts (to add new dynamic routes), confirming it touched the exact files involved in this regression.

Root Cause

In src/ROUTES.ts, the DYNAMIC_ROUTES.SPEND_CATEGORY_SELECTOR.entryScreens array was not updated when SCREENS.WORKSPACE.CATEGORIES_SETTINGS was renamed to SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGS by PR #88842. The getStateFromPath helper strictly checks that the focused route's screen name is in entryScreens before permitting navigation; since the name no longer matches, navigation falls through to the "Not here" (not found) page.

The fix is a one-line change: replace SCREENS.WORKSPACE.CATEGORIES_SETTINGS with SCREENS.WORKSPACE.DYNAMIC_CATEGORIES_SETTINGS in the SPEND_CATEGORY_SELECTOR.entryScreens array. A clean revert of PR #88842 is also viable.