[Due for payment 2026-05-22] [$250] Always show green Submit GBR/button when report is ready to submit, regardless of violations

[MelvinBot]

Updated 2026-05-13: Revised per aimane-chnaif's direction — clarified button behavior by role.

Product Change: Always show green "Submit" when report is ready to submit

Slack thread: https://expensify.slack.com/archives/C07HPDRELLD/p1777764861688339

Requirements

1. LHN: Remove red Fix RBR entirely. When a report is ready to submit, always show a green Submit GBR/badge — whether or not there are violations.
2. Report preview button by role:
   • Submitter always sees a green Submit button
   • Everyone else (approver, admin, etc.) sees a gray View button

Relevant Code

• OptionRowLHN.tsx:105 — Badge text gated behind !isProduction; needs to always show "Submit" GBR when ready
• reportAttributes.ts:283-303 — Brick road status and action badge assignment; violation-based RBR should not produce red "Fix"
• ReportUtils.ts:9140-9215 — getViolatingReportIDForRBRInLHN — drives the violation-based red indicator
• SubmitActionButton.tsx:60-73 — Submit button success prop controlled by isWaitingForSubmissionFromCurrentUser; should always be true (green) when the report is submittable, regardless of violations
• ReportPreviewActionUtils.ts:65 — canSubmit check; should only return true for the submitter (not manager or admin)

Report: https://new.expensify.com/e/4127904458237660

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022054659423900286541
• Upwork Job ID: 2054659423900286541
• Last Price Increase: 2026-05-13

Issue Owner

Current Issue Owner: @mallenexpensify

[aimane-chnaif]

@MelvinBot implement this

[aimane-chnaif]

@MelvinBot implement this

[MelvinBot]

🤖 Draft PR created: #89446
Please mark it as "Ready for review" when it is ready for review.

[MelvinBot]

🤖 Updated the issue title and body per quinthar's direction:

1. LHN: Remove red Fix RBR entirely — always show a green Submit GBR/badge when the report is ready to submit, regardless of violations.
2. Report preview: Always show a green Submit button, even when there are violations (no gray state).

Note: there is an existing draft PR at #89446 from the previous issue scope — it will likely need to be updated to match the revised requirements.

[aimane-chnaif]

@MelvinBot implement this in new PR

[MelvinBot]

🤖 Draft PR created: #89889
Please mark it as "Ready for review" when it is ready for review.

[MelvinBot]

⏱️ Ran out of time before I could finish. This usually means the task was too complex or I got stuck exploring. Please try again with a more specific request or post in #melvinbot-ai.

Run details

[aimane-chnaif]

• Submitter always sees a green Submit button
• Everyone else (approver, admin, etc) sees a gray View button

@MelvinBot update this in #89889 and in OP of this issue

[MelvinBot]

🤖 Updated PR #89889 and the issue body with the revised requirements:

• Submitter → green Submit button
• Everyone else (approver, admin, etc.) → gray View button

The change restricts canSubmit in ReportPreviewActionUtils.ts to only return true for the report submitter (owner). Managers and admins now fall through to the default gray View button.