[Due for Payment 2026-05-18][$250] Netsuite - Invoice item in export setting displays different value from the default

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.3.49-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/folder/13176904/test-cases/41237413
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Regression TC Execution
Device used: Windows 11 / Chrome, Android 16 / Samsung Galaxy A06
App Component: Workspace Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Connet to NetSuite
3. Go to export
4. Take note of the value displayed in Invoice Item
5. Click on Invoice item to see the default value

Expected Result:

Invoice item in export page displays "Create one for me" matching the default value

Actual Result:

Invoice item in export page displays "EST99999" as if the default value is "Select existing"

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari

Screenshots/Videos

Bug7114285_1774549920076.Recording__161.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trasnake87

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~022037255418286005199
• Upwork Job ID: 2037255418286005199
• Last Price Increase: 2026-04-30

[MelvinBot]

Proposal

What is the root cause of that problem?

The display logic for the Invoice Item field on the NetSuite export configuration page doesn't treat an unset (undefined) invoiceItemPreference as equivalent to the CREATE default.

In NetSuiteExportConfigurationPage.tsx:68-75, the code initializes invoiceItemValue to "Create one for me", but then enters an if/else chain:

1. First branch checks config?.invoiceItemPreference === 'create' — this is false when the preference is undefined (never explicitly set by the user).
2. Second branch checks selectedItem — this is always truthy when NetSuite items exist, because findSelectedInvoiceItemWithDefaultSelect falls back to items[0] when no specific item is selected.
3. So the display shows the first item's name (e.g., "EST99999") instead of "Create one for me".

The invoiceItemPreference field is optional on NetSuiteConnectionConfig, meaning it's undefined for workspaces that never changed it. Notably, the preference selection page already handles this correctly by using ?? CONST.NETSUITE_INVOICE_ITEM_PREFERENCE.CREATE — but the export config page's display logic does not.

What changes do you think we should make in order to solve the problem?

In src/pages/workspace/accounting/netsuite/export/NetSuiteExportConfigurationPage.tsx, change the condition on the first branch from:

config?.invoiceItemPreference === CONST.NETSUITE_INVOICE_ITEM_PREFERENCE.CREATE

to:

!config?.invoiceItemPreference || config?.invoiceItemPreference === CONST.NETSUITE_INVOICE_ITEM_PREFERENCE.CREATE

This treats undefined (unset) the same as 'create', matching the default behavior already established in the preference selection page. When this condition is true, the display will correctly show "Create one for me" and skip the selectedItem branch.

What alternative solutions did you explore? (Optional)

An alternative would be to change findSelectedInvoiceItemWithDefaultSelect to not fall back to items[0] when no item is explicitly selected. However, this function may be intentionally designed for the item selection page where showing a default selection is appropriate. The display logic fix is more targeted and doesn't risk side effects on other pages.

---

Next Steps for Contributor+ team: Reply with @MelvinBot implement this to create a draft PR, @MelvinBot <your feedback> to refine this analysis, or explain why you are rejecting Melvin's proposal.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~022037255418286005199

[trasnake87]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Invoice Item field on the NetSuite export settings page shows "EST99999" (the first NetSuite item) instead of "Create one for me" when the user has never explicitly set an invoice item preference.

What is the root cause of that problem?

The root cause is in findSelectedInvoiceItemWithDefaultSelect being called unconditionally on line 66 of NetSuiteExportConfigurationPage.tsx. This function always falls back to invoiceItems?.[0] when no matching item is found, so selectedItem is always truthy when items exist. The display logic on lines 68–75 then hits the else if (selectedItem) branch, showing the first item's name instead of the default "Create one for me" label.

What changes do you think we should make in order to solve the problem?

In NetSuiteExportConfigurationPage.tsx, only resolve selectedItem when the preference is explicitly SELECT. This way, when the preference is unset or CREATE, selectedItem is undefined and the initial "Create one for me" value is preserved.

- const selectedItem = findSelectedInvoiceItemWithDefaultSelect(items, config?.invoiceItem);
+ const selectedItem =
+     config?.invoiceItemPreference === CONST.NETSUITE_INVOICE_ITEM_PREFERENCE.SELECT
+         ? findSelectedInvoiceItemWithDefaultSelect(items, config?.invoiceItem)
+         : undefined;

This is safe because findSelectedInvoiceItemWithDefaultSelect with its fallback-to-first-item behavior is only meaningful when the user has chosen "Select existing". The downstream display logic on lines 68–75 then works correctly without any changes — unset/create preferences show "Create one for me", and the select preference shows the selected (or first) item name.

What alternative solutions did you explore?

We could instead modify the if/else chain conditions (lines 69–75), but fixing the data computation at the source is cleaner — it prevents selectedItem from ever having a misleading value when the preference isn't "select", which could guard against future display bugs as well.

[trasnake87]

Contributor details
Your Expensify account email: trasnake87@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~010f770315ab181656

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[ohrytskov]

🚫 Duplicated proposal withdrawn by 🤖 ProposalPolice.

[github-actions]

⚠️ @ohrytskov Your proposal is a duplicate of an already existing proposal and has been automatically withdrawn to prevent spam. Please review the existing proposals before submitting a new one.